From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support Date: Tue, 18 Sep 2012 08:03:39 -0400 Message-ID: <20120918120339.GS27758@beef> References: <1347902538-21208-1-git-send-email-mporter@ti.com> <1347902538-21208-2-git-send-email-mporter@ti.com> <5058063E.40509@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Tony Lindgren , Mark Brown , Linux Kernel Mailing List , AnilKumar , Linux SPI Devel List , Linux OMAP List , Linux ARM Kernel List To: Shubhrajyoti Return-path: Content-Disposition: inline In-Reply-To: <5058063E.40509-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Sep 18, 2012 at 10:57:26AM +0530, Shubhrajyoti wrote: > On Monday 17 September 2012 10:52 PM, Matt Porter wrote: > > Adds pinctrl support to support OMAP platforms that boot from DT > > and rely on pinctrl support to set pinmuxes. > > > > Signed-off-by: Matt Porter > > --- > looks good to me. > you may want to repost with Mark in cc to review. > Acked-by: Shubhrajyoti D Thanks...reposted this part with Mark cced. -Matt > > drivers/spi/spi-omap2-mcspi.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > > index b2fb141..9502566 100644 > > --- a/drivers/spi/spi-omap2-mcspi.c > > +++ b/drivers/spi/spi-omap2-mcspi.c > > @@ -38,6 +38,8 @@ > > #include > > #include > > #include > > +#include > > +#include > > > > #include > > > > @@ -1124,6 +1126,7 @@ static int __devinit omap2_mcspi_probe(struct platform_device *pdev) > > static int bus_num = 1; > > struct device_node *node = pdev->dev.of_node; > > const struct of_device_id *match; > > + struct pinctrl *pinctrl; > > > > master = spi_alloc_master(&pdev->dev, sizeof *mcspi); > > if (master == NULL) { > > @@ -1219,6 +1222,11 @@ static int __devinit omap2_mcspi_probe(struct platform_device *pdev) > > if (status < 0) > > goto dma_chnl_free; > > > > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > > + if (IS_ERR(pinctrl)) > > + dev_warn(&pdev->dev, > > + "pins are not configured from the driver\n"); > > + > > pm_runtime_use_autosuspend(&pdev->dev); > > pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT); > > pm_runtime_enable(&pdev->dev); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/