From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume Date: Wed, 26 Sep 2012 13:19:46 +0100 Message-ID: <20120926121946.GO4428@opensource.wolfsonmicro.com> References: <1348658647-25975-1-git-send-email-vipulkumar.samar@st.com> <1348658647-25975-2-git-send-email-vipulkumar.samar@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ulf Hansson , Vipul Kumar Samar , linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, "Rafael J. Wysocki" , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Linus Walleij Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote: > On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar > > SPI functional clock must be disalble/enable in non RTPM suspend/resume > > hooks. Currently it is only done for RTPM cases. > > This patch add support to disable/enbale clock for conventional > > suspend/resume calls. > Cross dependency between runtime suspend/resume and > common suspend/resume. Oh the horror ... This should be fine, we runtime resume before we suspend. > The semantics between runtime suspend/resume and > ordinary suspend/resume are unclear to me, it seems like > this is all up to the drivers and busses to figure out. Like > you weren't supposed to use both at the same time. This was clarified at some point relatively recently with the above (which is essentially the same as the solution you describe). ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/