From: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Vipul Kumar Samar <vipulkumar.samar-qxv4g6HH51o@public.gmane.org>,
Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM"
Date: Tue, 23 Oct 2012 12:48:42 +0100 [thread overview]
Message-ID: <20121023114842.GA4293@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121023114723.GU21164-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On Tue, Oct 23, 2012 at 12:47:23PM +0100, Russell King - ARM Linux wrote:
> On Tue, Oct 23, 2012 at 12:41:31PM +0100, Mark Brown wrote:
> > On Tue, Oct 23, 2012 at 12:16:56PM +0100, Russell King - ARM Linux wrote:
> > > On Tue, Oct 23, 2012 at 12:10:19PM +0100, Mark Brown wrote:
> >
> > > > I *really* should not need to remind you to:
> >
> > > > - Not top post
> > > > - Send patches in a form which can be applied if you want them applying
> >
> > > How about actually applying the damned patch from the two-part patch set,
> > > rather than only the first, both of which has been around for almost a
> > > month now, and fixes what should never have gone into mainline in the
> > > first place?
> >
> > Well, the reason for the second point is that I don't have a copy of the
> > patch any more, I need a copy of it before I can do anything. Half the
> > reason these contentless top posts are annoying is that even if there's
> > something to do it's not actionable.
> >
> > I have to say I had been under the impression that Linus' series that I
> > applied the other day dealt with all the outstanding stuff here; the
> > issues with this have been the awful changelogs and the overalapping
> > sets of patches.
>
> Given that Linus is the one who introduced the fuckups in the first place,
> and afaics Linus' series has not been posted anywhere I can see, and I
> have been through the issues and worked with Ulf to get them fixed, I find
> that to be down right insulting by you.
>
> You received *BOTH* of Ulf's patches on the 5th October. Both needed
> to be applied *TOGETHER* to reduce the window where things got worse
> before they got better. But for some goddamned unknown reason you decided
> to only take the first but totally and utterly ignored the second.
>
> Well done, you've probably crapped this driver up again. Way to go Mark.
> Now, tell us _exactly_ what patches you've applied to this driver. Post
> them to this mailing list so we can see them, and see what state this
> driver is now in.
>
> IMHO, you're being a terrible "maintainer" here - and this is being shown
> by the need to get you to post all the patches you've currently queued up
> for this.
Oh, and if you're unwilling to do that, then I'm taking both of Ulf's
patches, committing them to my fixes branch, and sending them off to
Linus tonight - because they are _NEEDED_ for the -rc series to fix
this driver.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
next prev parent reply other threads:[~2012-10-23 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 15:51 [PATCH 1/2] Revert "spi/pl022: fix spi-pl022 pm enable at probe" Ulf Hansson
[not found] ` <1349452272-4002-1-git-send-email-ulf.hansson-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2012-10-05 15:51 ` [PATCH 2/2] Revert "spi/pl022: enable runtime PM" Ulf Hansson
[not found] ` <1349452272-4002-2-git-send-email-ulf.hansson-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2012-10-23 10:31 ` Ulf Hansson
2012-10-23 11:10 ` Mark Brown
[not found] ` <20121023111019.GV4477-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-23 11:16 ` Russell King - ARM Linux
2012-10-23 11:41 ` Mark Brown
[not found] ` <20121023114130.GW4477-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-23 11:47 ` Russell King - ARM Linux
[not found] ` <20121023114723.GU21164-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-10-23 11:48 ` Russell King - ARM Linux [this message]
2012-10-23 13:01 ` Mark Brown
2012-10-23 12:29 ` Mark Brown
2012-10-23 12:42 ` Linus Walleij
2012-10-17 6:59 ` [PATCH 1/2] Revert "spi/pl022: fix spi-pl022 pm enable at probe" Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023114842.GA4293@n2100.arm.linux.org.uk \
--to=linux-lfz/pmaqli7xmaaqvzeohq@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=vipulkumar.samar-qxv4g6HH51o@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).