Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM"

From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Vipul Kumar Samar <vipulkumar.samar@st.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	spi-devel-general@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM"
Date: Tue, 23 Oct 2012 13:29:48 +0100	[thread overview]
Message-ID: <20121023122948.GY4477@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121023114723.GU21164@n2100.arm.linux.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 2668 bytes --]

On Tue, Oct 23, 2012 at 12:47:23PM +0100, Russell King - ARM Linux wrote:
> On Tue, Oct 23, 2012 at 12:41:31PM +0100, Mark Brown wrote:

> > I have to say I had been under the impression that Linus' series that I
> > applied the other day dealt with all the outstanding stuff here; the
> > issues with this have been the awful changelogs and the overalapping
> > sets of patches.

> Given that Linus is the one who introduced the fuckups in the first place,
> and afaics Linus' series has not been posted anywhere I can see, and I
> have been through the issues and worked with Ulf to get them fixed, I find
> that to be down right insulting by you.

Linus' patches were all posted to spi-devel-general.  I can understand
why you wouldn't subscribe to it given that it's a sourceforge list and
hence full of spam but it is the list of record for SPI unfortunately.

> You received *BOTH* of Ulf's patches on the 5th October.  Both needed
> to be applied *TOGETHER* to reduce the window where things got worse
> before they got better.  But for some goddamned unknown reason you decided
> to only take the first but totally and utterly ignored the second.

Unfortunately Ulf's original posting of the patches didn't include any
analysis of the problems or explanation as to why the reverts were
needed.  Since I had no idea what the patches were supposed to do having
not been involved in whatever discussion of the bugs were I didn't apply
them then.

Ulf did repost with a slightly clarified changelog and I *suspect* that
the second patch just got fat fingered due to the multiple different
revisions of the series that were floating around.

> Well done, you've probably crapped this driver up again.  Way to go Mark.
> Now, tell us _exactly_ what patches you've applied to this driver.  Post
> them to this mailing list so we can see them, and see what state this
> driver is now in.

> IMHO, you're being a terrible "maintainer" here - and this is being shown
> by the need to get you to post all the patches you've currently queued up
> for this.

As one would expect all the patches that are currently sitting there for
the driver are in -next already; one of the nice things about -next is
that it does tend to help remove doubt about things like this.

You just pointed me at the discussion of the original issue that
happened prior to Ulf's revert posting; I now see what's going on, your
analysis is crystal clear [1].  I'm just generating the extra revert of
2fb30d (spi/pl022: enable runtime PM) which I'll squash down into the
existing revert and send to Linus tomorrow.

[1] http://lists.arm.linux.org.uk/lurker/message/20120927.152412.d281a899.en.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel