From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] Revert "spi/pl022: enable runtime PM" Date: Tue, 23 Oct 2012 13:29:48 +0100 Message-ID: <20121023122948.GY4477@opensource.wolfsonmicro.com> References: <1349452272-4002-1-git-send-email-ulf.hansson@stericsson.com> <1349452272-4002-2-git-send-email-ulf.hansson@stericsson.com> <20121023111019.GV4477@opensource.wolfsonmicro.com> <20121023111656.GT21164@n2100.arm.linux.org.uk> <20121023114130.GW4477@opensource.wolfsonmicro.com> <20121023114723.GU21164@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1398853267431496369==" Cc: Ulf Hansson , Vipul Kumar Samar , Viresh Kumar , Linus Walleij , Grant Likely , spi-devel-general@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org To: Russell King - ARM Linux Return-path: In-Reply-To: <20121023114723.GU21164@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org --===============1398853267431496369== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Tln/wzp9jsNjmSUr" Content-Disposition: inline --Tln/wzp9jsNjmSUr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 23, 2012 at 12:47:23PM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 23, 2012 at 12:41:31PM +0100, Mark Brown wrote: > > I have to say I had been under the impression that Linus' series that I > > applied the other day dealt with all the outstanding stuff here; the > > issues with this have been the awful changelogs and the overalapping > > sets of patches. > Given that Linus is the one who introduced the fuckups in the first place, > and afaics Linus' series has not been posted anywhere I can see, and I > have been through the issues and worked with Ulf to get them fixed, I find > that to be down right insulting by you. Linus' patches were all posted to spi-devel-general. I can understand why you wouldn't subscribe to it given that it's a sourceforge list and hence full of spam but it is the list of record for SPI unfortunately. > You received *BOTH* of Ulf's patches on the 5th October. Both needed > to be applied *TOGETHER* to reduce the window where things got worse > before they got better. But for some goddamned unknown reason you decided > to only take the first but totally and utterly ignored the second. Unfortunately Ulf's original posting of the patches didn't include any analysis of the problems or explanation as to why the reverts were needed. Since I had no idea what the patches were supposed to do having not been involved in whatever discussion of the bugs were I didn't apply them then. Ulf did repost with a slightly clarified changelog and I *suspect* that the second patch just got fat fingered due to the multiple different revisions of the series that were floating around. > Well done, you've probably crapped this driver up again. Way to go Mark. > Now, tell us _exactly_ what patches you've applied to this driver. Post > them to this mailing list so we can see them, and see what state this > driver is now in. > IMHO, you're being a terrible "maintainer" here - and this is being shown > by the need to get you to post all the patches you've currently queued up > for this. As one would expect all the patches that are currently sitting there for the driver are in -next already; one of the nice things about -next is that it does tend to help remove doubt about things like this. You just pointed me at the discussion of the original issue that happened prior to Ulf's revert posting; I now see what's going on, your analysis is crystal clear [1]. I'm just generating the extra revert of 2fb30d (spi/pl022: enable runtime PM) which I'll squash down into the existing revert and send to Linus tomorrow. [1] http://lists.arm.linux.org.uk/lurker/message/20120927.152412.d281a899.en.html --Tln/wzp9jsNjmSUr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQho2jAAoJELSic+t+oim9JFYP/0q9tnocFUuYui5QtVt8O91U tX3K8yL5Kq6qRuWgKfNkmcTfGZWDgnlboYUoieDg4en8yQErsHl8T/iPiXKO73kv 3p466UbF41O+wf/OfWqnpyTj+5jGVvTFVJ0U2i0jWk0kN0nsw9ZiDfbQm+/FQ5B4 w75tnjLoqf+YssFMEIUObf4sjBYN3CsX+5fkMvLV5bVj6TT2CSHY5f3WUamzp60p aYFcHMIUZ67NH160RRSH5PKfxcLEQJPUzjF8pzpOFN35WGhaH9VoyyyhukgTvme7 U4rlSzaUJL5Q5N3OnxM3NVhbpDEfSFjssoO3veSPGknEg5gcezbfEcnGyE0PrRJB ZbF7D8FiRvY6cjvJB5ulPivV735mEALHtlLvxmOv6PJ2qkDxqdC2ot6JXMT958ou FvFfIulsoSfAp6ijB3xOxhL8NPPunB18hFhy2Y1lL2uNv91/LZNKtR2PnC09wIxG nveBcempvqW2WVnppyJLfpqSC2DWp2074CLu+XS9UoTM5DKiEnhvmy/q5xbyYm8/ OkXVKoD6RsRKTFPanWvtY0FVwNypY+AvltMyCZ1Smh2bRCGxqg9PKfPvHLSDfmru 2hCZ00QGhq6/GyDZ3/qeIlEPvt8sW7BZ3q3AQuGDvvTEo5woW3DhuQOq4AGa7wJ+ 5/eWxJ+7iUMLYvV2seKd =gitJ -----END PGP SIGNATURE----- --Tln/wzp9jsNjmSUr-- --===============1398853267431496369== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1398853267431496369==--