linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Revert "spi/pl022: enable runtime PM"
@ 2012-10-23 12:08 Ulf Hansson
  2012-10-23 13:08 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hansson @ 2012-10-23 12:08 UTC (permalink / raw)
  To: Mark Brown, Grant Likely,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
  Cc: Ulf Hansson, Vipul Kumar Samar, Russell King, Viresh Kumar,
	Linus Walleij, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

From: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99.

This patch introduced runtime PM issues and is not needed at all.
Thus we should revert it.

Conflicts:

	drivers/spi/spi-pl022.c

Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---

This patch is based on linux next as of 2012-10-23.
Latest patch for spi-pl022 driver was this one:

spi/pl022: add IDLE state pin management

---
 drivers/spi/spi-pl022.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 0205d47..1361868 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2192,9 +2192,6 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id)
 	printk(KERN_INFO "pl022: mapped registers from 0x%08x to %p\n",
 	       adev->res.start, pl022->virtbase);
 
-	pm_runtime_enable(dev);
-	pm_runtime_resume(dev);
-
 	pl022->clk = devm_clk_get(&adev->dev, NULL);
 	if (IS_ERR(pl022->clk)) {
 		status = PTR_ERR(pl022->clk);
@@ -2298,7 +2295,6 @@ pl022_remove(struct amba_device *adev)
 
 	clk_disable(pl022->clk);
 	clk_unprepare(pl022->clk);
-	pm_runtime_disable(&adev->dev);
 	amba_release_regions(adev);
 	tasklet_disable(&pl022->pump_transfers);
 	spi_unregister_master(pl022->master);
-- 
1.7.10


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Revert "spi/pl022: enable runtime PM"
  2012-10-23 12:08 [PATCH] Revert "spi/pl022: enable runtime PM" Ulf Hansson
@ 2012-10-23 13:08 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-10-23 13:08 UTC (permalink / raw)
  To: Ulf Hansson
  Cc: Ulf Hansson, Vipul Kumar Samar, Russell King, Viresh Kumar,
	Linus Walleij, Grant Likely, spi-devel-general, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 330 bytes --]

On Tue, Oct 23, 2012 at 02:08:36PM +0200, Ulf Hansson wrote:
> From: Ulf Hansson <ulf.hansson@linaro.org>
> 
> This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99.
> 
> This patch introduced runtime PM issues and is not needed at all.
> Thus we should revert it.

As covered elsewhere I applied a revert myself.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-23 13:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-23 12:08 [PATCH] Revert "spi/pl022: enable runtime PM" Ulf Hansson
2012-10-23 13:08 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).