From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH V2] spi: tegra: add spi driver for SLINK controller Date: Tue, 30 Oct 2012 15:14:51 +0000 Message-ID: <20121030151451.GT4511@opensource.wolfsonmicro.com> References: <1351531104-1604-1-git-send-email-ldewangan@nvidia.com> <508ED5A5.3000703@wwwdotorg.org> <508F6906.7020704@nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="e9fMjeYs+GPci+mg" Cc: Stephen Warren , "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Laxman Dewangan Return-path: Content-Disposition: inline In-Reply-To: <508F6906.7020704-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org --e9fMjeYs+GPci+mg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 30, 2012 at 11:13:34AM +0530, Laxman Dewangan wrote: > On Tuesday 30 October 2012 12:44 AM, Stephen Warren wrote: > >I think it depends on DMAENGINE, not the specific driver now, doesn't it? > Taking example from the mfd, we depends on particular driver, not > from the core driver. > I like to have this depends on Tegra20_apb_dma. The reason MFDs do this is that the function drivers usually directly reference the core driver in some way, for example by relying on data structures it sets up. With DMA that should all be hidden behind the dmaengine API. --e9fMjeYs+GPci+mg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQj+7JAAoJELSic+t+oim9cLEP/27j1SH9q3Pbc/epbs1hqYl9 /klO4ftaYVHGxgs1v/cpUUEH9Q4hDIpMKilXhYoz4jDStC4HZF5N+TU1ZgdZRg/Z SH0sJwZzYr9aFBIc3nnJTsJ8/rWM77CArG9/LOugPrmvdALXesizZZkkVWv9IC5K sw7VuvimrbnmdPeqf3h7R5UF7nHCPWCNZYZKXwI4l3VmpvVtrKCLFrSErYZw6ySr kdRWfg2bTZA2O5oQ6sxplLUG5ZDjsBEoQHeDXTp6TmuXmU72zldkl3JG8EYNGIZn wJjFVMgKt1iXIhKw/1trU2CTgkji2mhoc96Y6gIFzuDE7cLXpuauzlV0oyIrqTG7 q76CP46bsaSPGsXB/5jYBNvFdPGXM994lFbJlGSsXdOQCw/leeAch0Vg5UhtMtHT bYgYotaguzK1SUAjEzi9dHi3JFuSF4gzVbZaHiahUJlTC2mcBFTwjng5cpYWuTrw JXzxmXxIdt+CjHyR/A2CXYuUEU1/5Zd3pDY2nh2QgP0yV6tR5P0JizhoYJXqd9xO QavwUAj+/rfX2vnW69o36J6KnNQNu7m4JcxZwjlKPoAhftu9cRlPMpZVLmOLHZ/Q SAeVQ/71++3ZvwzcP8s6BrMuGZG2tUvTTGiiqKWMn3m1KDSlseHfdBufbj2jpFwu jf1hzEb6LEUuiTYxufaG =2lpI -----END PGP SIGNATURE----- --e9fMjeYs+GPci+mg--