From: Grant Likely <grant.likely@secretlab.ca>
To: Bastian Hecht <hechtb@gmail.com>,
spi-devel-general@lists.sourceforge.net
Cc: Magnus Damm <magnus.damm@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] spi: sh-msiof: Remove unneeded clock name
Date: Thu, 06 Dec 2012 14:05:15 +0000 [thread overview]
Message-ID: <20121206140515.75E6B3E089D@localhost> (raw)
In-Reply-To: <1352288407-20594-2-git-send-email-hechtb@gmail.com>
On Wed, 7 Nov 2012 12:40:04 +0100, Bastian Hecht <hechtb@gmail.com> wrote:
> clk_get() no longer needs a character string for associating the right
> clock as this is done via the device struct now.
>
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
Applied, thanks.
g.
> ---
> drivers/spi/spi-sh-msiof.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index 1f466bc..96358d0 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
> @@ -597,7 +597,6 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)
> struct resource *r;
> struct spi_master *master;
> struct sh_msiof_spi_priv *p;
> - char clk_name[16];
> int i;
> int ret;
>
> @@ -614,10 +613,9 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)
> p->info = pdev->dev.platform_data;
> init_completion(&p->done);
>
> - snprintf(clk_name, sizeof(clk_name), "msiof%d", pdev->id);
> - p->clk = clk_get(&pdev->dev, clk_name);
> + p->clk = clk_get(&pdev->dev, NULL);
> if (IS_ERR(p->clk)) {
> - dev_err(&pdev->dev, "cannot get clock \"%s\"\n", clk_name);
> + dev_err(&pdev->dev, "cannot get clock\n");
> ret = PTR_ERR(p->clk);
> goto err1;
> }
> --
> 1.7.5.4
>
>
> ------------------------------------------------------------------------------
> LogMeIn Central: Instant, anywhere, Remote PC access and management.
> Stay in control, update software, and manage PCs from one command center
> Diagnose problems and improve visibility into emerging IT issues
> Automate, monitor and manage. Do more in less time with Central
> http://p.sf.net/sfu/logmein12331_d2d
> _______________________________________________
> spi-devel-general mailing list
> spi-devel-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/spi-devel-general
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
next prev parent reply other threads:[~2012-12-06 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 11:40 [PATCH RESEND 0/4] spi: sh-msiof: Add DT support Bastian Hecht
2012-11-07 11:40 ` [PATCH 1/4] spi: sh-msiof: Remove unneeded clock name Bastian Hecht
2012-12-06 14:05 ` Grant Likely [this message]
2012-11-07 11:40 ` [PATCH 2/4] spi: Add SH Mobile series as dependency to MSIOF controller Bastian Hecht
2012-11-07 11:40 ` [PATCH 3/4] spi: sh-msiof: Add device tree parsing to driver Bastian Hecht
2012-12-06 14:14 ` Grant Likely
2012-11-07 11:40 ` [PATCH 4/4] devicetree: Add Renesas SH Mobile MSIOF spi controller binding doc Bastian Hecht
2012-12-06 14:08 ` Grant Likely
2012-12-06 14:13 ` Grant Likely
2012-12-12 11:26 ` Bastian Hecht
-- strict thread matches above, loose matches on Subject: below --
2012-09-21 11:00 [PATCH 1/4] spi: sh-msiof: Remove unneeded clock name Bastian Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206140515.75E6B3E089D@localhost \
--to=grant.likely@secretlab.ca \
--cc=hechtb@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).