[PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[Andreas Larsson]

This series removes the dependency on !SPARC for OF_I2C and removes the
depencency of !defined(CONFIG_SPARC) for the function
of_register_spi_devices. I find no reason for these to be unavailable
for sparc.

I am not sure if these should go through the sparc tree or the
corresponding subsystem trees.

Andreas Larsson (2):
  of_i2c: sparc: Allow OF_I2C for sparc
  spi: sparc: Allow of_register_spi_devices for sparc

 drivers/of/Kconfig |    2 +-
 drivers/spi/spi.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/2] of_i2c: sparc: Allow OF_I2C for sparc

[Andreas Larsson]

Signed-off-by: Andreas Larsson <andreas@gaisler.com>
---
 drivers/of/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index dfba3e6..d37bfcf 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -53,7 +53,7 @@ config OF_DEVICE
 
 config OF_I2C
 	def_tristate I2C
-	depends on I2C && !SPARC
+	depends on I2C
 	help
 	  OpenFirmware I2C accessors
 
-- 
1.7.0.4

Re: [PATCH 1/2] of_i2c: sparc: Allow OF_I2C for sparc

[David Miller]

From: Andreas Larsson <andreas@gaisler.com>
Date: Tue,  4 Dec 2012 15:09:37 +0100

> Signed-off-by: Andreas Larsson <andreas@gaisler.com>

Applied.

[PATCH 2/2] spi: sparc: Allow of_register_spi_devices for sparc

[Andreas Larsson]

Signed-off-by: Andreas Larsson <andreas@gaisler.com>
---
 drivers/spi/spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index c4f7d71..d8339fe 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -812,7 +812,7 @@ err_init_queue:
 
 /*-------------------------------------------------------------------------*/
 
-#if defined(CONFIG_OF) && !defined(CONFIG_SPARC)
+#if defined(CONFIG_OF)
 /**
  * of_register_spi_devices() - Register child devices onto the SPI bus
  * @master:	Pointer to spi_master device
-- 
1.7.0.4

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[Grant Likely]

On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas@gaisler.com> wrote:
> This series removes the dependency on !SPARC for OF_I2C and removes the
> depencency of !defined(CONFIG_SPARC) for the function
> of_register_spi_devices. I find no reason for these to be unavailable
> for sparc.
>
> I am not sure if these should go through the sparc tree or the
> corresponding subsystem trees.

They should go through the subsystem trees.

What build testing have you done on these patches?

g.

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[Andreas Larsson]

On 2012-12-04 15:44, Grant Likely wrote:
> On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas@gaisler.com> wrote:
>> This series removes the dependency on !SPARC for OF_I2C and removes the
>> depencency of !defined(CONFIG_SPARC) for the function
>> of_register_spi_devices. I find no reason for these to be unavailable
>> for sparc.
>>
>> I am not sure if these should go through the sparc tree or the
>> corresponding subsystem trees.
>
> They should go through the subsystem trees.
>
> What build testing have you done on these patches?

I have built under sparc32 (leon sparc to be specific) and have 
confirmed that of_register_spi_devices and of_i2c_register_devices works 
fine.

Cheers,
Andreas

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[David Miller]

From: Grant Likely <grant.likely@secretlab.ca>
Date: Tue, 4 Dec 2012 14:44:57 +0000

> On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas@gaisler.com> wrote:
>> This series removes the dependency on !SPARC for OF_I2C and removes the
>> depencency of !defined(CONFIG_SPARC) for the function
>> of_register_spi_devices. I find no reason for these to be unavailable
>> for sparc.
>>
>> I am not sure if these should go through the sparc tree or the
>> corresponding subsystem trees.
> 
> They should go through the subsystem trees.

I'll take this into the sparc tree after some build testing, thanks.

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On Tue, Dec 04, 2012 at 04:10:01PM -0500, David Miller wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Tue, 4 Dec 2012 14:44:57 +0000
> 
> > On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas@gaisler.com> wrote:
> >> This series removes the dependency on !SPARC for OF_I2C and removes the
> >> depencency of !defined(CONFIG_SPARC) for the function
> >> of_register_spi_devices. I find no reason for these to be unavailable
> >> for sparc.
> >>
> >> I am not sure if these should go through the sparc tree or the
> >> corresponding subsystem trees.
> > 
> > They should go through the subsystem trees.
> 
> I'll take this into the sparc tree after some build testing, thanks.

Checking git history, looks like Grant added the OF-I2C helpers in
2010-06 and some SPARC OF rework was done in 2010-10. Makes sense.

So, if those are going via SPARC tree:

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[Grant Likely]

On Tue, Dec 4, 2012 at 9:10 PM, David Miller <davem@davemloft.net> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Tue, 4 Dec 2012 14:44:57 +0000
>
>> On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas@gaisler.com> wrote:
>>> This series removes the dependency on !SPARC for OF_I2C and removes the
>>> depencency of !defined(CONFIG_SPARC) for the function
>>> of_register_spi_devices. I find no reason for these to be unavailable
>>> for sparc.
>>>
>>> I am not sure if these should go through the sparc tree or the
>>> corresponding subsystem trees.
>>
>> They should go through the subsystem trees.
>
> I'll take this into the sparc tree after some build testing, thanks.

I'd prefer to take the SPI one through my tree, but I won't get my
knickers in a knot if you insist.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[David Miller]

From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Date: Tue, 4 Dec 2012 21:49:26 +0000

> On Tue, Dec 4, 2012 at 9:10 PM, David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> wrote:
>> From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> Date: Tue, 4 Dec 2012 14:44:57 +0000
>>
>>> On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org> wrote:
>>>> This series removes the dependency on !SPARC for OF_I2C and removes the
>>>> depencency of !defined(CONFIG_SPARC) for the function
>>>> of_register_spi_devices. I find no reason for these to be unavailable
>>>> for sparc.
>>>>
>>>> I am not sure if these should go through the sparc tree or the
>>>> corresponding subsystem trees.
>>>
>>> They should go through the subsystem trees.
>>
>> I'll take this into the sparc tree after some build testing, thanks.
> 
> I'd prefer to take the SPI one through my tree, but I won't get my
> knickers in a knot if you insist.

That's fine:

Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

[Grant Likely]

On Fri, 07 Dec 2012 12:30:57 -0500 (EST), David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> wrote:
> From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Date: Tue, 4 Dec 2012 21:49:26 +0000
> 
> > On Tue, Dec 4, 2012 at 9:10 PM, David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> wrote:
> >> From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> >> Date: Tue, 4 Dec 2012 14:44:57 +0000
> >>
> >>> On Tue, Dec 4, 2012 at 2:09 PM, Andreas Larsson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org> wrote:
> >>>> This series removes the dependency on !SPARC for OF_I2C and removes the
> >>>> depencency of !defined(CONFIG_SPARC) for the function
> >>>> of_register_spi_devices. I find no reason for these to be unavailable
> >>>> for sparc.
> >>>>
> >>>> I am not sure if these should go through the sparc tree or the
> >>>> corresponding subsystem trees.
> >>>
> >>> They should go through the subsystem trees.
> >>
> >> I'll take this into the sparc tree after some build testing, thanks.
> > 
> > I'd prefer to take the SPI one through my tree, but I won't get my
> > knickers in a knot if you insist.
> 
> That's fine:
> 
> Acked-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

Applied, thanks.

g.


-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.