From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH] spi: Fix comparison of different integer types
Date: Fri, 7 Dec 2012 12:48:06 +0900 [thread overview]
Message-ID: <20121207034804.GC26070@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1354836947-31078-1-git-send-email-grant.likely@secretlab.ca>
On Thu, Dec 06, 2012 at 11:35:47PM +0000, Grant Likely wrote:
> Fix problem discovered with sparse:
> + drivers/spi/spi.c:1554:37: sparse: incompatible types in comparison expression (different signedness)
> drivers/spi/spi.c: In function 'spi_write_then_read':
> drivers/spi/spi.c:1554:23: warning: comparison of distinct pointer types lacks a cast [enabled by default]
>
> The change to SPI_BUFSIZ was introduced in commit b3a223ee2, "spi:
> Remove SPI_BUFSIZ restriction on spi_write_then_read()"
Thanks.
prev parent reply other threads:[~2012-12-07 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 23:35 [PATCH] spi: Fix comparison of different integer types Grant Likely
2012-12-07 3:48 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207034804.GC26070@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).