From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). Date: Wed, 19 Dec 2012 15:11:54 +0000 Message-ID: <20121219151154.937EC3E0AD7@localhost> References: <1355271894-5284-1-git-send-email-tipecaml@gmail.com> <1355271894-5284-6-git-send-email-tipecaml@gmail.com> <87txrsqf7f.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kuninori Morimoto , Cyril Roelandt Return-path: In-Reply-To: <87txrsqf7f.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto wrote: > > Hi > > > According to its documentation, clk_get() returns a "valid IS_ERR() condition > > containing errno", so we should call IS_ERR() rather than a NULL check. > > > > Signed-off-by: Cyril Roelandt > > Acked-by: Kuninori Morimoto Applied, thanks. g. ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d