From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Jun Chen <jun.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bi Chao <chao.bi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not.
Date: Wed, 19 Dec 2012 16:21:42 +0000 [thread overview]
Message-ID: <20121219162142.9E1123E0B72@localhost> (raw)
In-Reply-To: <20121219090416.GK4985-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On Wed, 19 Dec 2012 09:04:16 +0000, Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
> On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote:
>
> > This spi_alloc_device function will be called in the spi_new_device
> > function to alloc new device as the master. But other way, it is called
> > by the of_register_spi_devices function to register new device as the
> > children of the master. I will update changlog to add it.
>
> But why is this a bad thing? You've said what's happening but not why
> it's a problem.
spi_devices should always be children of the spi_master. If that is not
the case then it is a bug to be fixed.
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
next prev parent reply other threads:[~2012-12-19 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:29 [PATCH] spi: Add the flag indicate to registe new device as children of master or not Jun Chen
2012-12-18 15:26 ` Mark Brown
[not found] ` <20121218152623.GA26077-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-12-19 9:44 ` Jun Chen
2012-12-19 9:04 ` Mark Brown
[not found] ` <20121219090416.GK4985-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-12-19 16:21 ` Grant Likely [this message]
2012-12-21 17:39 ` Jun Chen
2012-12-21 19:06 ` Grant Likely
2012-12-24 16:16 ` Jun Chen
2013-01-11 14:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219162142.9E1123E0B72@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=chao.bi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jun.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).