From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). Date: Wed, 19 Dec 2012 19:39:14 +0300 Message-ID: <20121219163914.GN5032@mwanda> References: <1355271894-5284-1-git-send-email-tipecaml@gmail.com> <1355271894-5284-6-git-send-email-tipecaml@gmail.com> <87txrsqf7f.wl%kuninori.morimoto.gx@renesas.com> <20121219151154.937EC3E0AD7@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Cyril Roelandt , Kuninori Morimoto , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Return-path: Content-Disposition: inline In-Reply-To: <20121219151154.937EC3E0AD7@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote: > On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto wrote: > > > > Hi > > > > > According to its documentation, clk_get() returns a "valid IS_ERR() condition > > > containing errno", so we should call IS_ERR() rather than a NULL check. > > > > > > Signed-off-by: Cyril Roelandt > > > > Acked-by: Kuninori Morimoto > > Applied, thanks. In another thread, we were just talking about who clk_get() can return a NULL if !CONFIG_HAVE_CLK. That might change to match the documentation later... Not sure. regards, dan carpenter ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d