From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH] spi: spi-mpc512x-psc: don't use obsolet cell-index property Date: Fri, 11 Jan 2013 00:12:12 +0100 Message-ID: <20130111001212.3dd2c79a@crub> References: <1356100981-18685-1-git-send-email-agust@denx.de> <20121221192914.77D523E03CE@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Grant Likely Return-path: In-Reply-To: <20121221192914.77D523E03CE@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Hi Grant, On Fri, 21 Dec 2012 19:29:14 +0000 Grant Likely wrote: > On Fri, 21 Dec 2012 14:48:38 +0000, Grant Likely wrote: > > On Fri, Dec 21, 2012 at 2:43 PM, Anatolij Gustschin wrote: > > > Use unique PSCx register base offset to obtain the > > > SPI PSC number used for SPI bus id. > > > > > > Signed-off-by: Anatolij Gustschin > > > > Don't do this. If you really want to assign a specific bus number, > > then use a property in /aliases. cell-index has been deprecated a very > > long time ago now. > > Ummm.. I really should read patches before I reply to them. I see you're > removing cell-index, not adding it back in. It is fine. > > Aliases would be a more generic solution though. Would this following > change work for you? Try it out and let me know. Sorry for delay. I've tried it now, it doesn't work. The mpc5121 psc spi driver also needs to get/enable psc clock of the used psc controller. It uses psc bus number to generate psc clock name string and to get and enable this clock, so I need to set the bus number in the driver. I'll use of_alias_get_id() in the the psc spi driver. Thanks, Anatolij ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712