* [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message
@ 2013-01-30 20:33 John Crispin
[not found] ` <1359578011-7073-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: John Crispin @ 2013-01-30 20:33 UTC (permalink / raw)
To: Grant Likely
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Thomas Langer,
John Crispin
Rather than calling m->complete() directly we choose the sane way and call
spi_finalize_current_message instead.
Signed-off-by: Thomas Langer <thomas.langer-th3ZBGNqt+7QT0dZR+AlfA@public.gmane.org>
Signed-off-by: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
---
drivers/spi/spi-falcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-falcon.c b/drivers/spi/spi-falcon.c
index 6a6f62e..f9c66c2 100644
--- a/drivers/spi/spi-falcon.c
+++ b/drivers/spi/spi-falcon.c
@@ -398,7 +398,7 @@ static int falcon_sflash_xfer_one(struct spi_master *master,
}
m->status = ret;
- m->complete(m->context);
+ spi_finalize_current_message(master);
return 0;
}
--
1.7.10.4
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] SPI: MIPS: lantiq: set SPI_MASTER_HALF_DUPLEX flag
[not found] ` <1359578011-7073-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
@ 2013-01-30 20:33 ` John Crispin
[not found] ` <1359578011-7073-2-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 17:17 ` [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message Grant Likely
1 sibling, 1 reply; 4+ messages in thread
From: John Crispin @ 2013-01-30 20:33 UTC (permalink / raw)
To: Grant Likely
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Thomas Langer,
John Crispin
Due to hardware limitations of the spi/flash frontend of the EBU we need to set
the SPI_MASTER_HALF_DUPLEX flag.
Signed-off-by: Thomas Langer <thomas.langer-th3ZBGNqt+7QT0dZR+AlfA@public.gmane.org>
Signed-off-by: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
---
drivers/spi/spi-falcon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-falcon.c b/drivers/spi/spi-falcon.c
index f9c66c2..c7a74f0 100644
--- a/drivers/spi/spi-falcon.c
+++ b/drivers/spi/spi-falcon.c
@@ -423,6 +423,7 @@ static int falcon_sflash_probe(struct platform_device *pdev)
master->mode_bits = SPI_MODE_3;
master->num_chipselect = 1;
+ master->flags = SPI_MASTER_HALF_DUPLEX;
master->bus_num = -1;
master->setup = falcon_sflash_setup;
master->prepare_transfer_hardware = falcon_sflash_prepare_xfer;
--
1.7.10.4
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message
[not found] ` <1359578011-7073-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-01-30 20:33 ` [PATCH 2/2] SPI: MIPS: lantiq: set SPI_MASTER_HALF_DUPLEX flag John Crispin
@ 2013-02-05 17:17 ` Grant Likely
1 sibling, 0 replies; 4+ messages in thread
From: Grant Likely @ 2013-02-05 17:17 UTC (permalink / raw)
To: John Crispin
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Thomas Langer,
John Crispin
On Wed, 30 Jan 2013 21:33:30 +0100, John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> wrote:
> Rather than calling m->complete() directly we choose the sane way and call
> spi_finalize_current_message instead.
>
> Signed-off-by: Thomas Langer <thomas.langer-th3ZBGNqt+7QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Applied, thanks.
g.
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] SPI: MIPS: lantiq: set SPI_MASTER_HALF_DUPLEX flag
[not found] ` <1359578011-7073-2-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
@ 2013-02-05 17:17 ` Grant Likely
0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2013-02-05 17:17 UTC (permalink / raw)
To: John Crispin
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, Thomas Langer,
John Crispin
On Wed, 30 Jan 2013 21:33:31 +0100, John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> wrote:
> Due to hardware limitations of the spi/flash frontend of the EBU we need to set
> the SPI_MASTER_HALF_DUPLEX flag.
>
> Signed-off-by: Thomas Langer <thomas.langer-th3ZBGNqt+7QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Applied, thanks.
g.
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-05 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-30 20:33 [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message John Crispin
[not found] ` <1359578011-7073-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-01-30 20:33 ` [PATCH 2/2] SPI: MIPS: lantiq: set SPI_MASTER_HALF_DUPLEX flag John Crispin
[not found] ` <1359578011-7073-2-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-02-05 17:17 ` Grant Likely
2013-02-05 17:17 ` [PATCH 1/2] SPI: MIPS: lantiq: make use of spi_finalize_current_message Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).