From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count Date: Sun, 10 Feb 2013 23:56:31 +0000 Message-ID: <20130210235631.DD54D3E0C13@localhost> References: <1359471223-4794-1-git-send-email-andreas@gaisler.com> <1359471223-4794-3-git-send-email-andreas@gaisler.com> Cc: Rob Herring , Linus Walleij , devicetree-discuss@lists.ozlabs.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, software@gaisler.com To: Andreas Larsson Return-path: In-Reply-To: <1359471223-4794-3-git-send-email-andreas@gaisler.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Tue, 29 Jan 2013 15:53:39 +0100, Andreas Larsson wrote: > This lets of_gpio_named_count return an errno on errors by being able to > distinguish between reaching the end of the phandle list and getting some other > error from of_parse_phandle_with_args. > > Return error from of_spi_register_master when there is an "cs-gpios" list for > which gp_gpio_named_count fails. > > Adjust various drivers cope with error return from of_gpio_named_count, > including via of_gpio_count. > > Signed-off-by: Andreas Larsson Actually, I'd been meaning to fix of_gpio_count for quite a while now. The current code uses a stupid algorithm to parse each specifier one at a time and count how many iterations it takes before getting an error. BLECH! A pox on me for being so lazy when I wrote it. Anyway, your patch here spurred me on to fix it. I've just done so and will post the patch in a few minutes. Please test and let me know if it works for you. g.