From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master Date: Tue, 12 Feb 2013 17:09:48 +0000 Message-ID: <20130212170948.C5BA63E07C5@localhost> References: <1359471223-4794-1-git-send-email-andreas@gaisler.com> <1359471223-4794-6-git-send-email-andreas@gaisler.com> <20130211002220.AFCA83E0C13@localhost> <511A0DB6.1080702@gaisler.com> Cc: Rob Herring , Linus Walleij , devicetree-discuss@lists.ozlabs.org, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, software@gaisler.com To: Andreas Larsson Return-path: In-Reply-To: <511A0DB6.1080702@gaisler.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Tue, 12 Feb 2013 10:39:02 +0100, Andreas Larsson wrote: > On 2013-02-11 01:22, Grant Likely wrote: > > On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson wrote: > >> When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs to be > >> known to the controller driver. > >> > >> Signed-off-by: Andreas Larsson > > > > Out of curiosity, what do you need the flags for? Polarity of the CS > > signal? I think it is long past time to revisit baking polarity control > > into core of gpiolib. Would you mind investigating doing that instead of > > having to manage it manually in each and every driver? > > I don't even need it on my hardware. It seemed like a good thing to have > via of_spi_register_master. I am OK with just dropping this. Hahaha. Okay, let's leave it for now until someone does need it. I can however see the need for the polarity flag, so the request still stands for someone to put that feature into the core. :-) g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.