From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization Date: Sat, 02 Mar 2013 22:27:10 +0000 Message-ID: <20130302222710.AE2143E2E65@localhost> References: <001b01ce10d3$e9f78620$bde69260$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: 'Kukjin Kim' , 'Russell King' , 'Vinod Koul' , 'Mark Brown' , 'Rob Herring' , 'Sangbeom Kim' , 'Dan Williams' To: Boojin Kim , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org Return-path: In-Reply-To: <001b01ce10d3$e9f78620$bde69260$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote: > This patch adds dma maxburst size initialization. > The maxburst should be set by MODE_CFGn.DMA_TYPE, > because the pl330 dma driver supports burst mode. > > Signed-off-by: Hyeonkook Kim Acked-by: Grant Likely This series probably needs to be merged together through the arm-soc tree. g. > --- > drivers/spi/spi-s3c64xx.c | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index e862ab8..5e6cafe 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -287,10 +287,20 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, > struct s3c64xx_spi_driver_data *sdd; > struct samsung_dma_prep info; > struct samsung_dma_config config; > + void __iomem *regs; > + unsigned int mode_cfg; > > if (dma->direction == DMA_DEV_TO_MEM) { > sdd = container_of((void *)dma, > struct s3c64xx_spi_driver_data, rx_dma); > + > + regs = sdd->regs; > + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG); > + if (mode_cfg & S3C64XX_SPI_MODE_4BURST) > + config.maxburst = 4; > + else > + config.maxburst = 1; > + > config.direction = sdd->rx_dma.direction; > config.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA; > config.width = sdd->cur_bpw / 8; > @@ -298,6 +308,14 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, > } else { > sdd = container_of((void *)dma, > struct s3c64xx_spi_driver_data, tx_dma); > + > + regs = sdd->regs; > + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG); > + if (mode_cfg & S3C64XX_SPI_MODE_4BURST) > + config.maxburst = 4; > + else > + config.maxburst = 1; > + > config.direction = sdd->tx_dma.direction; > config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA; > config.width = sdd->cur_bpw / 8; > -- > 1.7.5.4 > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb