From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's Date: Sat, 02 Mar 2013 22:56:17 +0000 Message-ID: <20130302225617.405D23E3209@localhost> References: <1360785828-32767-1-git-send-email-ks.giri@samsung.com> <1360785828-32767-4-git-send-email-ks.giri@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Girish K S , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <1360785828-32767-4-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, 13 Feb 2013 12:03:46 -0800, Girish K S wrote: > Currently the drivers supports only the GPIO based i/o pins. > But there are Exynos SoC's that use the same controller with > dedicated i/o pins. > > This patch provides provision to support gpio/dedicated pins. > The decision is made by parsing the "gpios" property in the spi > node. > > Signed-off-by: Girish K S > --- > changes in v2: > Removed the gpio quirk. Parse the "gpios" property > to decide whether gpio / dedicated i/o lines should > be used. It is perfectly valid to support both at the same time. The gpios property can be 'sparse' in that when a gpio is specified, use that for the CS control, but use a dedicated line with it is not. Instead of doing this it would be better off to switch this driver to use the new cs_gpios parsing in driver/spi/spi.c g. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb