From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca,
richard.genoud@gmail.com, plagnioj@jcrosoft.com,
nicolas.ferre@atmel.com, JM.Lin@atmel.com,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for lock operations
Date: Mon, 1 Apr 2013 14:46:13 +0100 [thread overview]
Message-ID: <20130401134613.GY18636@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1363679163-3897-1-git-send-email-wenyou.yang@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
On Tue, Mar 19, 2013 at 03:46:03PM +0800, Wenyou Yang wrote:
> +static void atmel_spi_lock(struct atmel_spi *as)
> +{
> + spin_lock_irqsave(&as->lock, as->flags);
> +}
Coding style.
> - spin_unlock(&as->lock);
> + atmel_spi_unlock(as);
> msg->complete(msg->context);
> - spin_lock(&as->lock);
> + atmel_spi_lock(as);
This replaces non-irqsave versions with irqsave versions of the lock.
Is this safe/correct? If it is I'd have expected some sort of mention
of it in the commit log.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-01 13:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 7:41 [PATCH v7 00/14] spi/spi-atmel: add dmaengine support for atmel spi controller and to test the device tree support Wenyou Yang
2013-03-19 7:42 ` [PATCH v7 01/14] spi/spi-atmel: detect the capabilities of SPI core by reading the VERSION register Wenyou Yang
2013-04-01 13:38 ` Mark Brown
[not found] ` <1363678866-3567-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-03-19 7:43 ` [PATCH v7 02/14] spi/spi-atmel: add support transfer on CS1, 2, 3, not only on CS0 Wenyou Yang
2013-04-01 13:41 ` [PATCH v7 02/14] spi/spi-atmel: add support transfer on CS1,2,3, " Mark Brown
2013-03-19 7:43 ` [PATCH v7 03/14] spi/spi-atmel: add physical base address Wenyou Yang
2013-04-01 13:41 ` Mark Brown
[not found] ` <20130401134147.GV18636-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-04-02 5:49 ` Yang, Wenyou
2013-04-02 6:17 ` Yang, Wenyou
2013-03-19 7:46 ` [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for lock operations Wenyou Yang
2013-04-01 13:46 ` Mark Brown [this message]
[not found] ` <20130401134613.GY18636-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-04-03 5:09 ` Yang, Wenyou
2013-03-19 7:49 ` [PATCH v7 10/14] spi/spi-atmel: correct 16 bits transfers with DMA Wenyou Yang
2013-04-01 13:53 ` Mark Brown
2013-04-02 5:46 ` Yang, Wenyou
2013-03-19 7:51 ` [PATCH v7 13/14] ARM: dts: add spi nodes for the atmel boards Wenyou Yang
2013-03-21 9:32 ` [PATCH v7 00/14] spi/spi-atmel: add dmaengine support for atmel spi controller and to test the device tree support Nicolas Ferre
[not found] ` <514AD3A2.50203-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-03-22 9:26 ` Nicolas Ferre
2013-03-19 7:44 ` [PATCH v7 04/14] spi/spi-atmel: call unmapping on transfers buffers Wenyou Yang
2013-04-01 13:43 ` Mark Brown
2013-03-19 7:45 ` [PATCH v7 05/14] spi/spi-atmel: status information passed through controller data Wenyou Yang
2013-04-01 13:43 ` Mark Brown
2013-03-19 7:46 ` [PATCH v7 07/14] spi/spi-atmel: add dmaengine support Wenyou Yang
2013-03-19 7:47 ` [PATCH v7 08/14] spi/spi-atmel: fix spi-atmel driver to adapt to slave_config changes Wenyou Yang
2013-04-01 13:51 ` Mark Brown
2013-04-02 5:45 ` Yang, Wenyou
2013-03-19 7:47 ` [PATCH v7 09/14] spi/spi-atmel: correct 16 bits transfers using PIO Wenyou Yang
2013-04-01 13:53 ` Mark Brown
2013-03-19 7:49 ` [PATCH v7 11/14] ARM: at91: add clocks for spi dt entries Wenyou Yang
2013-03-19 7:50 ` [PATCH v7 12/14] ARM: dts: add spi nodes for atmel SoC Wenyou Yang
2013-03-19 7:52 ` [PATCH v7 14/14] ARM: dts: add pinctrl property for spi node " Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401134613.GY18636@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=JM.Lin@atmel.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=richard.genoud@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).