* [PATCH -next] mxs/spi: fix error return code in mxs_spi_probe()
@ 2013-04-03 13:06 Wei Yongjun
2013-04-03 17:37 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-04-03 13:06 UTC (permalink / raw)
To: grant.likely, broonie, rob.herring
Cc: yongjun_wei, spi-devel-general, devicetree-discuss, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/spi/spi-mxs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 7b1c014..8498276 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -570,6 +570,7 @@ static int mxs_spi_probe(struct platform_device *pdev)
ssp->dmach = dma_request_slave_channel(&pdev->dev, "rx-tx");
if (!ssp->dmach) {
dev_err(ssp->dev, "Failed to request DMA\n");
+ ret = -ENODEV;
goto out_master_free;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] mxs/spi: fix error return code in mxs_spi_probe()
2013-04-03 13:06 [PATCH -next] mxs/spi: fix error return code in mxs_spi_probe() Wei Yongjun
@ 2013-04-03 17:37 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-04-03 17:37 UTC (permalink / raw)
To: Wei Yongjun
Cc: grant.likely, rob.herring, yongjun_wei, spi-devel-general,
devicetree-discuss, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
On Wed, Apr 03, 2013 at 09:06:40PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-03 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-03 13:06 [PATCH -next] mxs/spi: fix error return code in mxs_spi_probe() Wei Yongjun
2013-04-03 17:37 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).