[PATCH] spi: hspi: fixup long delay time

[PATCH] spi: hspi: fixup long delay time

[Kuninori Morimoto]

Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
but it was too long delay for SPI device.
Bock-W board SPI access was too slow without this patch.
This patch uses udelay(10) for it.

Tested-by: Yusuke Goda <yusuke.goda.sx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-sh-hspi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
index 60cfae5..eab593e 100644
--- a/drivers/spi/spi-sh-hspi.c
+++ b/drivers/spi/spi-sh-hspi.c
@@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
 		if ((mask & hspi_read(hspi, SPSR)) == val)
 			return 0;
 
-		msleep(20);
+		udelay(10);
 	}
 
 	dev_err(hspi->dev, "timeout\n");
-- 
1.7.9.5


------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html

Re: [PATCH] spi: hspi: fixup long delay time

[Simon Horman]

On Thu, Apr 04, 2013 at 10:26:42PM -0700, Kuninori Morimoto wrote:
> Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
> but it was too long delay for SPI device.
> Bock-W board SPI access was too slow without this patch.
> This patch uses udelay(10) for it.
> 
> Tested-by: Yusuke Goda <yusuke.goda.sx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Acked-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

Grant, can you take this patch?

> ---
>  drivers/spi/spi-sh-hspi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
> index 60cfae5..eab593e 100644
> --- a/drivers/spi/spi-sh-hspi.c
> +++ b/drivers/spi/spi-sh-hspi.c
> @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
>  		if ((mask & hspi_read(hspi, SPSR)) == val)
>  			return 0;
>  
> -		msleep(20);
> +		udelay(10);
>  	}
>  
>  	dev_err(hspi->dev, "timeout\n");
> -- 
> 1.7.9.5
> 

------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html

Re: [PATCH] spi: hspi: fixup long delay time

[Kuninori Morimoto]

Hi Grant

Could you please teach me current status of this patch ?

> On Thu, Apr 04, 2013 at 10:26:42PM -0700, Kuninori Morimoto wrote:
> > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
> > but it was too long delay for SPI device.
> > Bock-W board SPI access was too slow without this patch.
> > This patch uses udelay(10) for it.
> > 
> > Tested-by: Yusuke Goda <yusuke.goda.sx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> Acked-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
> 
> Grant, can you take this patch?
> 
> > ---
> >  drivers/spi/spi-sh-hspi.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
> > index 60cfae5..eab593e 100644
> > --- a/drivers/spi/spi-sh-hspi.c
> > +++ b/drivers/spi/spi-sh-hspi.c
> > @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
> >  		if ((mask & hspi_read(hspi, SPSR)) == val)
> >  			return 0;
> >  
> > -		msleep(20);
> > +		udelay(10);
> >  	}
> >  
> >  	dev_err(hspi->dev, "timeout\n");
> > -- 
> > 1.7.9.5
> > 


Best regards
---
Kuninori Morimoto

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter

Re: [PATCH] spi: hspi: fixup long delay time

[Kuninori Morimoto]

Hi Grant

ping ?

> Hi Grant
> 
> Could you please teach me current status of this patch ?
> 
> > On Thu, Apr 04, 2013 at 10:26:42PM -0700, Kuninori Morimoto wrote:
> > > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
> > > but it was too long delay for SPI device.
> > > Bock-W board SPI access was too slow without this patch.
> > > This patch uses udelay(10) for it.
> > > 
> > > Tested-by: Yusuke Goda <yusuke.goda.sx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> > 
> > Acked-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
> > 
> > Grant, can you take this patch?
> > 
> > > ---
> > >  drivers/spi/spi-sh-hspi.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
> > > index 60cfae5..eab593e 100644
> > > --- a/drivers/spi/spi-sh-hspi.c
> > > +++ b/drivers/spi/spi-sh-hspi.c
> > > @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
> > >  		if ((mask & hspi_read(hspi, SPSR)) == val)
> > >  			return 0;
> > >  
> > > -		msleep(20);
> > > +		udelay(10);
> > >  	}
> > >  
> > >  	dev_err(hspi->dev, "timeout\n");
> > > -- 
> > > 1.7.9.5
> > > 
> 
> 
> Best regards
> ---
> Kuninori Morimoto


Best regards
---
Kuninori Morimoto

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

[PATCH] spi: hspi: fixup long delay time

[Kuninori Morimoto]

Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
but it was too long delay for SPI device.
Bock-W board SPI access was too slow without this patch.
This patch uses udelay(10) for it.

Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/spi/spi-sh-hspi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
index 60cfae5..eab593e 100644
--- a/drivers/spi/spi-sh-hspi.c
+++ b/drivers/spi/spi-sh-hspi.c
@@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
 		if ((mask & hspi_read(hspi, SPSR)) == val)
 			return 0;
 
-		msleep(20);
+		udelay(10);
 	}
 
 	dev_err(hspi->dev, "timeout\n");
-- 
1.7.9.5

Re: [PATCH 01/17 v2] spi: hspi: fixup long delay time

[Simon Horman]

On Wed, May 22, 2013 at 08:14:33PM -0700, Kuninori Morimoto wrote:
> Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
> but it was too long delay for SPI device.
> Bock-W board SPI access was too slow without this patch.
> This patch uses udelay(10) for it.
> 
> Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

I'm not quite sure of the history of this patch,
but I have added Mark Brown, Grant Likely and spi-devel-general
to the recipients of this email. Mark, Grant, is it possible
for you to pick this patch up?

> ---
> v1 -> v2
> 
>  - no change
> 
>  drivers/spi/spi-sh-hspi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
> index 60cfae5..eab593e 100644
> --- a/drivers/spi/spi-sh-hspi.c
> +++ b/drivers/spi/spi-sh-hspi.c
> @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
>  		if ((mask & hspi_read(hspi, SPSR)) == val)
>  			return 0;
>  
> -		msleep(20);
> +		udelay(10);
>  	}
>  
>  	dev_err(hspi->dev, "timeout\n");
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 01/17 v2] spi: hspi: fixup long delay time

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

On Sat, May 25, 2013 at 10:47:40AM +0900, Simon Horman wrote:

> I'm not quite sure of the history of this patch,
> but I have added Mark Brown, Grant Likely and spi-devel-general
> to the recipients of this email. Mark, Grant, is it possible
> for you to pick this patch up?

If someone sends me the patch...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 01/17 v2] spi: hspi: fixup long delay time

[Simon Horman]

On Sat, May 25, 2013 at 10:32:19AM -0400, Mark Brown wrote:
> On Sat, May 25, 2013 at 10:47:40AM +0900, Simon Horman wrote:
> 
> > I'm not quite sure of the history of this patch,
> > but I have added Mark Brown, Grant Likely and spi-devel-general
> > to the recipients of this email. Mark, Grant, is it possible
> > for you to pick this patch up?
> 
> If someone sends me the patch...

Morimoto-san,

could you please repost the patch with Mark, Grant and spi-devel-general
included in the recipient list?

[PATCH] spi: hspi: fixup long delay time

[Kuninori Morimoto]

Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
but it was too long delay for SPI device.
Bock-W board SPI access was too slow without this patch.
This patch uses udelay(10) for it.

Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/spi/spi-sh-hspi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c
index 60cfae5..eab593e 100644
--- a/drivers/spi/spi-sh-hspi.c
+++ b/drivers/spi/spi-sh-hspi.c
@@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val)
 		if ((mask & hspi_read(hspi, SPSR)) == val)
 			return 0;
 
-		msleep(20);
+		udelay(10);
 	}
 
 	dev_err(hspi->dev, "timeout\n");
-- 
1.7.9.5

Re: [PATCH] spi: hspi: fixup long delay time

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

On Sun, May 26, 2013 at 05:59:20PM -0700, Kuninori Morimoto wrote:
> Current HSPI driver is using msleep(20) on hspi_status_check_timeout(),
> but it was too long delay for SPI device.
> Bock-W board SPI access was too slow without this patch.
> This patch uses udelay(10) for it.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]