* [PATCH -next v2] spi: tegra: slink: make local symbols static
@ 2013-04-05 13:45 Wei Yongjun
[not found] ` <CAPgLHd-sTt5eKoiLb13dWHipT6Q46qCbG=b9mCYNq=Q7YLmGVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-04-05 13:45 UTC (permalink / raw)
To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
swarren-3lzwWm7+Weoh9ZMKESR00Q,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this
file so they can, and should, be static.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
drivers/spi/spi-tegra20-slink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 4e58b53..b224a82 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1087,11 +1087,11 @@ static struct tegra_spi_platform_data *tegra_slink_parse_dt(
return pdata;
}
-const struct tegra_slink_chip_data tegra30_spi_cdata = {
+static const struct tegra_slink_chip_data tegra30_spi_cdata = {
.cs_hold_time = true,
};
-const struct tegra_slink_chip_data tegra20_spi_cdata = {
+static const struct tegra_slink_chip_data tegra20_spi_cdata = {
.cs_hold_time = false,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <CAPgLHd-sTt5eKoiLb13dWHipT6Q46qCbG=b9mCYNq=Q7YLmGVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH -next v2] spi: tegra: slink: make local symbols static [not found] ` <CAPgLHd-sTt5eKoiLb13dWHipT6Q46qCbG=b9mCYNq=Q7YLmGVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2013-04-05 13:54 ` Thierry Reding 2013-04-08 12:41 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Thierry Reding @ 2013-04-05 13:54 UTC (permalink / raw) To: Wei Yongjun Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY, linux-tegra-u79uwXL29TY76Z2rM5mHXA, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f [-- Attachment #1.1: Type: text/plain, Size: 1224 bytes --] On Fri, Apr 05, 2013 at 09:45:36PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > > Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this > file so they can, and should, be static. > > Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > --- > drivers/spi/spi-tegra20-slink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c > index 4e58b53..b224a82 100644 > --- a/drivers/spi/spi-tegra20-slink.c > +++ b/drivers/spi/spi-tegra20-slink.c > @@ -1087,11 +1087,11 @@ static struct tegra_spi_platform_data *tegra_slink_parse_dt( > return pdata; > } > > -const struct tegra_slink_chip_data tegra30_spi_cdata = { > +static const struct tegra_slink_chip_data tegra30_spi_cdata = { > .cs_hold_time = true, > }; > > -const struct tegra_slink_chip_data tegra20_spi_cdata = { > +static const struct tegra_slink_chip_data tegra20_spi_cdata = { > .cs_hold_time = false, > }; > Reviewed-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> [-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 192 bytes --] _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] spi: tegra: slink: make local symbols static [not found] ` <CAPgLHd-sTt5eKoiLb13dWHipT6Q46qCbG=b9mCYNq=Q7YLmGVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-05 13:54 ` Thierry Reding @ 2013-04-08 12:41 ` Mark Brown 1 sibling, 0 replies; 3+ messages in thread From: Mark Brown @ 2013-04-08 12:41 UTC (permalink / raw) To: Wei Yongjun Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY, linux-tegra-u79uwXL29TY76Z2rM5mHXA, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f [-- Attachment #1.1: Type: text/plain, Size: 288 bytes --] On Fri, Apr 05, 2013 at 09:45:36PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > > Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this > file so they can, and should, be static. Applied, thanks. [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 192 bytes --] _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-08 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-05 13:45 [PATCH -next v2] spi: tegra: slink: make local symbols static Wei Yongjun
[not found] ` <CAPgLHd-sTt5eKoiLb13dWHipT6Q46qCbG=b9mCYNq=Q7YLmGVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-05 13:54 ` Thierry Reding
2013-04-08 12:41 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).