From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andreas Larsson <andreas@gaisler.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
spi-devel-general@lists.sourceforge.net,
Mingkai Hu <Mingkai.hu@freescale.com>,
Anton Vorontsov <anton.vorontsov@linaro.org>,
Joakim Tjernlund <Joakim.Tjernlund@transmode.se>,
Kumar Gala <galak@kernel.crashing.org>,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH v3 5/7] spi: spi-fsl-spi: Add support for setting a maximum number of bits per word
Date: Tue, 9 Apr 2013 17:57:38 +0100 [thread overview]
Message-ID: <20130409165738.GU9243@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1360943547-2186-6-git-send-email-andreas@gaisler.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Fri, Feb 15, 2013 at 04:52:25PM +0100, Andreas Larsson wrote:
> Acked-by: Anton Vorontsov <anton@enomsg.org>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
I'll apply this on account of it being part of the series and review
having been very slow but...
> /* Make sure its a bit width we support [4..16, 32] */
> if ((bits_per_word < 4)
> - || ((bits_per_word > 16) && (bits_per_word != 32)))
> + || ((bits_per_word > 16) && (bits_per_word != 32))
> + || (bits_per_word > mpc8xxx_spi->max_bits_per_word))
> return -EINVAL;
...we do have support for this in the core now, it would be good to
convert over to that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-09 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 15:52 [PATCH v3 0/7] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc Andreas Larsson
2013-02-15 15:52 ` [PATCH v3 4/7] spi: spi-fsl-spi: Introduce a type for the driver Andreas Larsson
[not found] ` <1360943547-2186-1-git-send-email-andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
2013-02-15 15:52 ` [PATCH v3 1/7] spi: spi-fsl-spi: Make driver usable in CPU mode outside of an FSL_SOC environment Andreas Larsson
2013-02-15 15:52 ` [PATCH v3 2/7] spi: spi-fsl-spi: Make sure in spi_fsl_setup that chipselect becomes inactive Andreas Larsson
2013-02-15 15:52 ` [PATCH v3 3/7] spi: spi-fsl-spi: Move setting non-zero tx and rx shifts to a function accessed by a function pointer Andreas Larsson
2013-02-15 15:52 ` [PATCH v3 5/7] spi: spi-fsl-spi: Add support for setting a maximum number of bits per word Andreas Larsson
2013-04-09 16:57 ` Mark Brown [this message]
2013-04-09 17:02 ` Mark Brown
2013-02-15 15:52 ` [PATCH v3 6/7] spi: spi-fsl-spi: Add support for Aeroflex Gaisler GRLIB cores normally running on SPARC Andreas Larsson
2013-02-15 15:52 ` [PATCH v3 7/7] spi: spi-fsl-spi: Add support for gpio chipselects for GRLIB type cores Andreas Larsson
2013-03-02 21:57 ` [PATCH v3 0/7] spi: spi-fsl-spi: Make spi-fsl-spi usable in cpu mode outside of FSL SOC environments and add a grlib variant normally running on sparc Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409165738.GU9243@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=Mingkai.hu@freescale.com \
--cc=andreas@gaisler.com \
--cc=anton.vorontsov@linaro.org \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=software@gaisler.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).