From: Mark Brown <broonie@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>, Daniel Mack <zonque@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Javier Martinez Canillas <martinez.javier@gmail.com>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
linux-omap@vger.kernel.org, ezequiel.garcia@free-electrons.com
Subject: Re: [PATCH] spi: spi-omap2-mcspi.c: Add dts for slave device configuration.
Date: Wed, 17 Apr 2013 16:11:24 +0100 [thread overview]
Message-ID: <20130417151124.GY13687@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1364252415-3613-1-git-send-email-matthias.bgg@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Mar 26, 2013 at 12:00:15AM +0100, Matthias Brugger wrote:
> +- The spi slave nodes can provide the following information which is used
> + by the spi controller.
> +- ti,spi-cs-per-word: Set chipselect to be toggled on every word send.
Why is this part of the DT binding for the SPI controller? Surely if
the devices attached to the SPI bus want to configure this they should
be setting things up appropriately in the transfers? There might be
devices that both want and do not want this on the same bus for example,
and this isn't something that should depend on controller support.
> +- ti,spi-turbo-mode: Set turbo mode for this device.
> + controller-data {
> + ti,spi-cs-per-word = <1>;
> + ti,spi-turbo-mode = <0>;
Better to use a boolean property here - check with of_find_property() to
see if the property is defined at all rather than using a value.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-17 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 23:00 [PATCH] spi: spi-omap2-mcspi.c: Add dts for slave device configuration Matthias Brugger
[not found] ` <1364252415-3613-1-git-send-email-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-08 12:18 ` Matthias Brugger
[not found] ` <CABuKBeKN+cPbsf95mTvDfzAwzOh4V-+bycp=sujNndDeMG2HMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-08 12:40 ` Mark Brown
2013-04-17 15:11 ` Mark Brown [this message]
[not found] ` <CAB=otbTtRN9xyO0whNz-UbW+Xo0_X8XWLcWZt=7MfUfrnNqwww@mail.gmail.com>
2013-05-14 9:53 ` Illia Smyrnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417151124.GY13687@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eballetbo@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).