* [PATCH] spi: hspi: fixup long delay time [not found] <87li7fwgk8.wl%kuninori.morimoto.gx@renesas.com> @ 2013-05-16 7:13 ` Kuninori Morimoto [not found] ` <87d2si4cdn.wl%kuninori.morimoto.gx@renesas.com> 1 sibling, 0 replies; 6+ messages in thread From: Kuninori Morimoto @ 2013-05-16 7:13 UTC (permalink / raw) To: Simon, Grant Likely Cc: Magnus, Linux-SH, Kuninori Morimoto, goda, spi-devel-general Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), but it was too long delay for SPI device. Bock-W board SPI access was too slow without this patch. This patch uses udelay(10) for it. Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/spi/spi-sh-hspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index 60cfae5..eab593e 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) if ((mask & hspi_read(hspi, SPSR)) == val) return 0; - msleep(20); + udelay(10); } dev_err(hspi->dev, "timeout\n"); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <87d2si4cdn.wl%kuninori.morimoto.gx@renesas.com>]
[parent not found: <87bo824cbu.wl%kuninori.morimoto.gx@renesas.com>]
* Re: [PATCH 01/17 v2] spi: hspi: fixup long delay time [not found] ` <87bo824cbu.wl%kuninori.morimoto.gx@renesas.com> @ 2013-05-25 1:47 ` Simon Horman 2013-05-25 14:32 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2013-05-25 1:47 UTC (permalink / raw) To: Kuninori Morimoto, Mark Brown, Grant Likely, spi-devel-general Cc: Magnus, Linux-SH, Kuninori Morimoto On Wed, May 22, 2013 at 08:14:33PM -0700, Kuninori Morimoto wrote: > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), > but it was too long delay for SPI device. > Bock-W board SPI access was too slow without this patch. > This patch uses udelay(10) for it. > > Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> I'm not quite sure of the history of this patch, but I have added Mark Brown, Grant Likely and spi-devel-general to the recipients of this email. Mark, Grant, is it possible for you to pick this patch up? > --- > v1 -> v2 > > - no change > > drivers/spi/spi-sh-hspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c > index 60cfae5..eab593e 100644 > --- a/drivers/spi/spi-sh-hspi.c > +++ b/drivers/spi/spi-sh-hspi.c > @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) > if ((mask & hspi_read(hspi, SPSR)) == val) > return 0; > > - msleep(20); > + udelay(10); > } > > dev_err(hspi->dev, "timeout\n"); > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/17 v2] spi: hspi: fixup long delay time 2013-05-25 1:47 ` [PATCH 01/17 v2] " Simon Horman @ 2013-05-25 14:32 ` Mark Brown 2013-05-26 13:28 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Mark Brown @ 2013-05-25 14:32 UTC (permalink / raw) To: Simon Horman Cc: Kuninori Morimoto, Grant Likely, spi-devel-general, Magnus, Linux-SH, Kuninori Morimoto [-- Attachment #1: Type: text/plain, Size: 310 bytes --] On Sat, May 25, 2013 at 10:47:40AM +0900, Simon Horman wrote: > I'm not quite sure of the history of this patch, > but I have added Mark Brown, Grant Likely and spi-devel-general > to the recipients of this email. Mark, Grant, is it possible > for you to pick this patch up? If someone sends me the patch... [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 01/17 v2] spi: hspi: fixup long delay time 2013-05-25 14:32 ` Mark Brown @ 2013-05-26 13:28 ` Simon Horman 2013-05-27 0:59 ` [PATCH] " Kuninori Morimoto 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2013-05-26 13:28 UTC (permalink / raw) To: Mark Brown Cc: Kuninori Morimoto, Grant Likely, spi-devel-general, Magnus, Linux-SH, Kuninori Morimoto On Sat, May 25, 2013 at 10:32:19AM -0400, Mark Brown wrote: > On Sat, May 25, 2013 at 10:47:40AM +0900, Simon Horman wrote: > > > I'm not quite sure of the history of this patch, > > but I have added Mark Brown, Grant Likely and spi-devel-general > > to the recipients of this email. Mark, Grant, is it possible > > for you to pick this patch up? > > If someone sends me the patch... Morimoto-san, could you please repost the patch with Mark, Grant and spi-devel-general included in the recipient list? ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] spi: hspi: fixup long delay time 2013-05-26 13:28 ` Simon Horman @ 2013-05-27 0:59 ` Kuninori Morimoto 2013-05-27 12:17 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Kuninori Morimoto @ 2013-05-27 0:59 UTC (permalink / raw) To: Mark Brown, Simon Horman, Grant Likely Cc: spi-devel-general, Magnus, Linux-SH, Kuninori Morimoto Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), but it was too long delay for SPI device. Bock-W board SPI access was too slow without this patch. This patch uses udelay(10) for it. Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/spi/spi-sh-hspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index 60cfae5..eab593e 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) if ((mask & hspi_read(hspi, SPSR)) == val) return 0; - msleep(20); + udelay(10); } dev_err(hspi->dev, "timeout\n"); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: hspi: fixup long delay time 2013-05-27 0:59 ` [PATCH] " Kuninori Morimoto @ 2013-05-27 12:17 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2013-05-27 12:17 UTC (permalink / raw) To: Kuninori Morimoto Cc: Simon Horman, Grant Likely, spi-devel-general, Magnus, Linux-SH, Kuninori Morimoto [-- Attachment #1: Type: text/plain, Size: 299 bytes --] On Sun, May 26, 2013 at 05:59:20PM -0700, Kuninori Morimoto wrote: > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), > but it was too long delay for SPI device. > Bock-W board SPI access was too slow without this patch. > This patch uses udelay(10) for it. Applied, thanks. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-27 12:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87li7fwgk8.wl%kuninori.morimoto.gx@renesas.com>
2013-05-16 7:13 ` [PATCH] spi: hspi: fixup long delay time Kuninori Morimoto
[not found] ` <87d2si4cdn.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <87bo824cbu.wl%kuninori.morimoto.gx@renesas.com>
2013-05-25 1:47 ` [PATCH 01/17 v2] " Simon Horman
2013-05-25 14:32 ` Mark Brown
2013-05-26 13:28 ` Simon Horman
2013-05-27 0:59 ` [PATCH] " Kuninori Morimoto
2013-05-27 12:17 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).