From: Gerhard Sittig <gsi-ynQEQJNshbs@public.gmane.org>
To: Mark Brown <broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Cc: Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
dzu-ynQEQJNshbs@public.gmane.org
Subject: Re: [PATCH v1 1/3] spi: mpc512x: minor prep before feature change
Date: Tue, 4 Jun 2013 20:45:14 +0200 [thread overview]
Message-ID: <20130604184514.GJ2571@book.gsilab.sittig.org> (raw)
In-Reply-To: <20130604172059.GI31367-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On Tue, Jun 04, 2013 at 18:21 +0100, Mark Brown wrote:
>
> On Mon, Jun 03, 2013 at 02:03:49PM +0200, Gerhard Sittig wrote:
> > mechanical edits before changing functionality, to reduce diffs
> > [ ... ]
>
> Applied but in future if you're submitting a bunch of unrelated changes
> each change should go in a separate patch. This makes review easier as
> it makes it easier to tell if the patch does what the description
> claims.
Understood. Thank you for the review and feedback.
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office-ynQEQJNshbs@public.gmane.org
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
next prev parent reply other threads:[~2013-06-04 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 12:03 [PATCH v1 0/3] spi: mpc512x: increase throughput, use subsystem queue Gerhard Sittig
[not found] ` <1370261031-28572-1-git-send-email-gsi-ynQEQJNshbs@public.gmane.org>
2013-06-03 12:03 ` [PATCH v1 1/3] spi: mpc512x: minor prep before feature change Gerhard Sittig
[not found] ` <20130604172059.GI31367@sirena.org.uk>
[not found] ` <20130604172059.GI31367-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-06-04 18:45 ` Gerhard Sittig [this message]
2013-06-03 12:03 ` [PATCH v1 2/3] spi: mpc512x: improve throughput in the RX/TX func Gerhard Sittig
2013-06-03 12:03 ` [PATCH v1 3/3] spi: mpc512x: use the SPI subsystem's message queue Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604184514.GJ2571@book.gsilab.sittig.org \
--to=gsi-ynqeqjnshbs@public.gmane.org \
--cc=broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).