From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH 3/8] spi: spi-ep93xx: always handle transfer specific settings Date: Sun, 30 Jun 2013 19:26:50 +0300 Message-ID: <20130630162650.GD786@mwesterb-mobl.lan> References: <201306281143.35130.hartleys@visionengravers.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Linux Kernel , Ryan Mallon To: H Hartley Sweeten Return-path: Content-Disposition: inline In-Reply-To: <201306281143.35130.hartleys-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Jun 28, 2013 at 11:43:34AM -0700, H Hartley Sweeten wrote: > __spi_async(), which starts every SPI message transfer, initializes > the bits_per_word and max speed for every transfer in the message. > Since the conditional test in ep93xx_spi_process_transfer() will > always succeed just remove it and always call ep93xx_spi_chip_setup() > to configure the hardware for each transfer in the message. > > Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer() > which just initializes the hardware to the "default" based on the SPI > device. > > Signed-off-by: H Hartley Sweeten > Cc: Ryan Mallon > Cc: Mika Westerberg Acked-by: Mika Westerberg ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev