From: Mika Westerberg <mika.westerberg@iki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
spi-devel-general@lists.sourceforge.net,
Ryan Mallon <rmallon@gmail.com>,
broonie@kernel.org, grant.likely@linaro.org,
hsweeten@visionengravers.com
Subject: Re: [PATCH v2 07/11] spi: spi-ep93xx: remove 'dss' from per chip private data
Date: Wed, 3 Jul 2013 21:06:57 +0300 [thread overview]
Message-ID: <20130703180657.GF26568@mwesterb-mobl.lan> (raw)
In-Reply-To: <201307021009.30230.hartleys@visionengravers.com>
On Tue, Jul 02, 2013 at 10:09:29AM -0700, H Hartley Sweeten wrote:
> This value is only needed to set the bits per word for each transfer
> of a message. There is no reason to set the value in ep93xx_spi_enable()
> because ep93xx_spi_process_transfer() sets it again for each transfer.
>
> Just pass the t->bits_per_word directly to ep93xx_spi_chip_setup() in
> ep93xx_spi_process_transfer() and remove 'dss' from the per chip private
> data.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Cc: Mika Westerberg <mika.westerberg@iki.fi>
Acked-by: Mika Westerberg <mika.westerberg@iki.fi>
next prev parent reply other threads:[~2013-07-03 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 17:09 [PATCH v2 07/11] spi: spi-ep93xx: remove 'dss' from per chip private data H Hartley Sweeten
2013-07-03 18:06 ` Mika Westerberg [this message]
2013-07-03 18:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703180657.GF26568@mwesterb-mobl.lan \
--to=mika.westerberg@iki.fi \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=hartleys@visionengravers.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).