From: Felipe Balbi <balbi@ti.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: <broonie@kernel.org>, <spi-devel-general@lists.sourceforge.net>,
<grant.likely@linaro.org>, <balbi@ti.com>, <rnayak@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv8 1/2] drivers: spi: Add qspi flash controller
Date: Thu, 1 Aug 2013 17:07:06 +0300 [thread overview]
Message-ID: <20130801140706.GT7918@radagast> (raw)
In-Reply-To: <1375365602-31321-2-git-send-email-sourav.poddar@ti.com>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Hi,
On Thu, Aug 01, 2013 at 07:30:01PM +0530, Sourav Poddar wrote:
> +static int ti_qspi_setup(struct spi_device *spi)
> +{
[snip]
> + pm_runtime_mark_last_busy(qspi->dev);
> + ret = pm_runtime_put_autosuspend(qspi->dev);
> + if (ret < 0) {
> + dev_err(qspi->dev, "pm_runtime_get_sync() failed\n");
wrong error message.
> +static int qspi_transfer_msg(struct ti_qspi *qspi, struct spi_transfer *t)
> +{
> + int ret;
> +
> + if (t->tx_buf) {
> + ret = qspi_write_msg(qspi, t);
> + if (ret) {
> + dev_dbg(qspi->dev, "Error while writing\n");
> + return -ETIMEDOUT;
return ret;
> + }
> + }
> +
> + if (t->rx_buf) {
> + ret = qspi_read_msg(qspi, t);
> + if (ret) {
> + dev_dbg(qspi->dev, "Error while writing\n");
> + return -ETIMEDOUT;
return ret;
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-01 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 14:00 [PATCHv8 0/2] Add ti qspi controller Sourav Poddar
[not found] ` <1375365602-31321-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2013-08-01 14:00 ` [PATCHv8 1/2] drivers: spi: Add qspi flash controller Sourav Poddar
2013-08-01 14:07 ` Felipe Balbi [this message]
2013-08-01 14:00 ` [RFC/PATCH 2/2] driver: spi: Add quad spi read support Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801140706.GT7918@radagast \
--to=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=sourav.poddar@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).