From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RFC] Remove "spi-cs-high" property for GPIO-based chipselects
Date: Mon, 2 Dec 2013 11:43:10 +0000 [thread overview]
Message-ID: <20131202114310.GP27568@sirena.org.uk> (raw)
In-Reply-To: <1385884756-31373-1-git-send-email-shc_work-JGs/UdohzUI@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Sun, Dec 01, 2013 at 11:59:16AM +0400, Alexander Shiyan wrote:
> This patch takes the CS active level from the GPIO bindings,
> so we remove the special property "spi-cs-high" for chipselects
> that use GPIO.
Unfortuantely this would introduce an incompatible change in the DT
bindings so we can't do this. Updating the documentation to deprecate
the old binding would be OK, though I'm not sure it's a great advantage
since it means you wouldn't be able to use the same binding with GPIOs
as you could with controller integrated chip selects.
Adding support for using the GPIO binding information is fine but
removing the old method (especially without a binding update) doesn't
seem great.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-02 11:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 7:59 [PATCH RFC] Remove "spi-cs-high" property for GPIO-based chipselects Alexander Shiyan
[not found] ` <1385884756-31373-1-git-send-email-shc_work-JGs/UdohzUI@public.gmane.org>
2013-12-02 11:43 ` Mark Brown [this message]
[not found] ` <20131202114310.GP27568-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-02 11:58 ` Alexander Shiyan
[not found] ` <1385985513.987194654-zxFGIbyeZotsdVUOrk1QfQ@public.gmane.org>
2013-12-02 12:33 ` Mark Brown
[not found] ` <20131202123339.GZ27568-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-02 12:42 ` Alexander Shiyan
[not found] ` <1385988152.848953040-u8tvknxLvilsdVUOrk1QfQ@public.gmane.org>
2013-12-02 12:46 ` Mark Brown
2013-12-02 13:49 ` Jonas Gorski
[not found] ` <CAOiHx=nAcGdk7QgKPrbmkbQYzWL6qNb2cnJj3c_A+9++RrLoeA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-02 14:54 ` Alexander Shiyan
[not found] ` <1385996099.869286515-/wTItXjRvv7WO3iv0lnsqw@public.gmane.org>
2013-12-02 18:03 ` Jonas Gorski
[not found] ` <CAOiHx=kLkiWjnuUV_1-rVrO-EDQw=Ut0eZE5egYrmiVK9wmxfw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-02 20:17 ` Gerhard Sittig
[not found] ` <20131202201722.GZ2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-12-02 22:09 ` Jonas Gorski
[not found] ` <CAOiHx=krrM+NZ7detAv9_UsB+bUXtKL0m4=pDHO30uduJsDdFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-02 22:36 ` Gerhard Sittig
[not found] ` <20131202223632.GA2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-12-03 4:23 ` Alexander Shiyan
2013-12-02 14:59 ` Gerhard Sittig
[not found] ` <20131202145911.GT2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-12-02 15:24 ` Alexander Shiyan
[not found] ` <1385997862.727371043-/wTItXjRvv7WO3iv0lnsqw@public.gmane.org>
2013-12-02 16:31 ` Gerhard Sittig
[not found] ` <20131202163124.GW2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-12-02 17:14 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202114310.GP27568@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shc_work-JGs/UdohzUI@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).