From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org
Cc: linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 03/11] spi: spi-sh-msiof: let it run even without GPIO
Date: Mon, 2 Dec 2013 12:53:20 +0000 [thread overview]
Message-ID: <20131202125320.GD27568@sirena.org.uk> (raw)
In-Reply-To: <1385921962-19843-3-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Mon, Dec 02, 2013 at 03:19:14AM +0900, takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org wrote:
> - /* use spi->controller data for CS (same strategy as spi_gpio) */
> - gpio_set_value((unsigned)spi->controller_data, value);
> + /* use spi->controller data for CS (same strategy as spi_gpio),
> + * if any. otherwise let HW controll CS */
> + if (spi->controller_data)
> + gpio_set_value((unsigned)spi->controller_data, value);
This makes sense in terms of what it tries to do however the standard
thing is to set the GPIO value to an error value if it isn't there
(especially since 0 is in theory a valid GPIO) so the test should be
different.
I'd also suggest changing to use the core cs_gpio field but that's a
separate thing.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-02 12:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 18:15 [PATCH 00/11] ARM: shmobile: koelsch: MSIOF support Takashi YOSHII
2013-12-01 18:19 ` [PATCH 01/11] pinctrl: sh-pfc: r8a7791: fix msiof groups to follow GROUP takasi-y
2013-12-01 18:19 ` [PATCH 03/11] spi: spi-sh-msiof: let it run even without GPIO takasi-y
2013-12-02 10:59 ` Sergei Shtylyov
[not found] ` <1385921962-19843-3-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-12-02 12:53 ` Mark Brown [this message]
2013-12-01 18:19 ` [PATCH 04/11] spi: spi-sh-msiof: set hi/low Active for HW CS takasi-y
[not found] ` <1385921962-19843-4-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-12-02 12:54 ` Mark Brown
2013-12-01 18:19 ` [PATCH 05/11] spi: spi-sh-msiof: rx_need_dummy_tx variant takasi-y
[not found] ` <1385921962-19843-5-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-12-02 17:49 ` Mark Brown
[not found] ` <1385921962-19843-1-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-12-01 18:19 ` [PATCH 02/11] spi: spi-sh-msiof: round up div to fix freq calculation takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-12-02 12:48 ` Mark Brown
2013-12-01 18:19 ` [PATCH 06/11] spi: spi-sh-msiof: RMDIR1[15:0] may should be zero takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-12-01 18:19 ` [PATCH 07/11] spi: spi-sh-msiof: RSCR register may absent takasi-y-nDL5PR/MsHhHfZP73Gtkiw
[not found] ` <1385921962-19843-7-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2014-02-12 16:06 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVVC1deEQfbLzPzU08LYxf=KOtG3oL2_M4HMBGvJE+8KQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-12 23:50 ` Simon Horman
2013-12-01 18:19 ` [PATCH 08/11] ARM: shmobile: r8a7791: Add MSIOF clocks takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-12-01 18:19 ` [PATCH 09/11] ARM: shmobile: r8a7791: MSIOF platform device takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-12-03 10:12 ` Linus Walleij
[not found] ` <CACRpkdbvrYgRh7cK0N1HrcxkYzzu9Qw4yAoQwj4f9pEf0r1qQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-05 3:02 ` Simon Horman
[not found] ` <20131205030235.GG21443-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-12-11 12:27 ` Linus Walleij
[not found] ` <CACRpkda=m_3Y+FcKUvAj4e1gDUuvqB4VS4bv6u-VnX4LVQQP8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-12 0:53 ` Olof Johansson
2013-12-01 18:19 ` [PATCH 10/11] ARM: shmobile: koelsch: pinctrl map for MSIOF0 takasi-y-nDL5PR/MsHhHfZP73Gtkiw
2013-12-03 10:13 ` Linus Walleij
2013-12-03 10:08 ` [PATCH 01/11] pinctrl: sh-pfc: r8a7791: fix msiof groups to follow GROUP Linus Walleij
2013-12-04 1:23 ` Laurent Pinchart
2013-12-01 18:19 ` [PATCH 11/11] ARM: shmobile: koelsch: spidev for r2a11302 takasi-y
[not found] ` <1385921962-19843-11-git-send-email-takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org>
2013-12-02 13:24 ` Mark Brown
2014-02-11 15:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202125320.GD27568@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=takasi-y-nDL5PR/MsHhHfZP73Gtkiw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).