From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] spi: spi-atmel: Use devm_*() functions
Date: Wed, 4 Dec 2013 11:59:21 +0000 [thread overview]
Message-ID: <20131204115921.GL29268@sirena.org.uk> (raw)
In-Reply-To: <529EFA38.7050404-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Wed, Dec 04, 2013 at 10:47:36AM +0100, Nicolas Ferre wrote:
> On 04/12/2013 06:07, Jingoo Han :
> > out_free_irq:
> >- free_irq(irq, master);
> > out_unmap_regs:
> > out_free_buffer:
> What about taking advantage of this cleanup patch to remove the 3
> above unneeded tags?
> Otherwise, you can add my:
> Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
That's a good idea but it means going and changing all the gotos as well
so it probably warrants a separate patch. I applied this one as-is.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-04 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 5:07 [PATCH 1/2] spi: spi-atmel: Use devm_*() functions Jingoo Han
[not found] ` <002b01cef0ae$c8261dc0$58725940$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-12-04 5:10 ` [PATCH 2/2] spi: coldfire-qspi: " Jingoo Han
[not found] ` <002c01cef0af$1b3a4630$51aed290$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-12-04 12:00 ` Mark Brown
2013-12-04 9:47 ` [PATCH 1/2] spi: spi-atmel: " Nicolas Ferre
[not found] ` <529EFA38.7050404-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-12-04 11:59 ` Mark Brown [this message]
[not found] ` <20131204115921.GL29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 12:07 ` Nicolas Ferre
2013-12-05 2:27 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204115921.GL29268@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).