From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH] spi: dt-binding: clarify gpio chipselect language Date: Thu, 5 Dec 2013 17:44:00 +0100 Message-ID: <20131205164400.GI12805@ns203013.ovh.net> References: <542dfeee809e73f7f071f4ae0b4f95af7736f70b.1386243545.git.baruch@tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark Brown , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely To: Baruch Siach Return-path: Content-Disposition: inline In-Reply-To: <542dfeee809e73f7f071f4ae0b4f95af7736f70b.1386243545.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 13:39 Thu 05 Dec , Baruch Siach wrote: > Commit 743179849015 (of_spi: add generic binding support to specify cs gpio) > introduced generic binding for gpio chip-select. The cs_gpio struct field, > however, is an internal implementation detail of the Linux SPI subsystem, and > should not be mentioned in the device tree binding documentation. Mention the > previously defined cs-gpios master node property instead. > > Cc: Jean-Christophe PLAGNIOL-VILLARD > Cc: Grant Likely > Signed-off-by: Baruch Siach > --- > Documentation/devicetree/bindings/spi/spi-bus.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt > index 800dafe..e5a4d1b 100644 > --- a/Documentation/devicetree/bindings/spi/spi-bus.txt > +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt > @@ -67,7 +67,7 @@ only 1(SINGLE), 2(DUAL) and 4(QUAD). > Dual/Quad mode is not allowed when 3-wire mode is used. > > If a gpio chipselect is used for the SPI slave the gpio number will be passed > -via the cs_gpio > +via the SPI master node cs-gpios property. here it's an information about the c structure Best Regards, J. > > SPI example for an MPC5200 SPI bus: > spi@f00 { > -- > 1.8.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html