From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michal Nazarewicz <mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
Cc: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
'Cory Maccarrone'
<darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] spi: omap-100k: Remove casting the return value which is a void pointer
Date: Mon, 9 Dec 2013 11:55:36 +0000 [thread overview]
Message-ID: <20131209115536.GR29268@sirena.org.uk> (raw)
In-Reply-To: <8761qyuv6g.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Mon, Dec 09, 2013 at 12:21:11PM +0100, Michal Nazarewicz wrote:
> On Mon, Dec 09 2013, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> > - spi100k->base = (void __iomem *)dev_get_platdata(&pdev->dev);
> > + spi100k->base = dev_get_platdata(&pdev->dev);
> I might be wrong, but I would assume that __iomem is the important bit
> here and removing this cast will make linter unhappy.
Yes, I'd expect so. Jingoo have you tested with sparse?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-09 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 10:36 [PATCH] spi: omap-100k: Remove casting the return value which is a void pointer Jingoo Han
[not found] ` <001801cef4ca$8c605e20$a5211a60$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-12-09 11:21 ` Michal Nazarewicz
[not found] ` <8761qyuv6g.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2013-12-09 11:55 ` Mark Brown [this message]
[not found] ` <20131209115536.GR29268-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-09 12:09 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209115536.GR29268@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=darkstar6262-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).