[PATCH] spi: omap-100k: Remove casting the return value which is a void pointer

[PATCH] spi: omap-100k: Remove casting the return value which is a void pointer

[Jingoo Han]

Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-omap-100k.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
index 0d32054..35832a9 100644
--- a/drivers/spi/spi-omap-100k.c
+++ b/drivers/spi/spi-omap-100k.c
@@ -441,7 +441,7 @@ static int omap1_spi100k_probe(struct platform_device *pdev)
 	 * You should allocate this with ioremap() before initializing
 	 * the SPI.
 	 */
-	spi100k->base = (void __iomem *)dev_get_platdata(&pdev->dev);
+	spi100k->base = dev_get_platdata(&pdev->dev);
 
 	spi100k->ick = devm_clk_get(&pdev->dev, "ick");
 	if (IS_ERR(spi100k->ick)) {
-- 
1.7.10.4


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: omap-100k: Remove casting the return value which is a void pointer

[Michal Nazarewicz]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Mon, Dec 09 2013, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Casting the return value which is a void pointer is redundant.
> The conversion from void pointer to any other pointer type is
> guaranteed by the C programming language.
>
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/spi/spi-omap-100k.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
> index 0d32054..35832a9 100644
> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -441,7 +441,7 @@ static int omap1_spi100k_probe(struct platform_device *pdev)
>  	 * You should allocate this with ioremap() before initializing
>  	 * the SPI.
>  	 */
> -	spi100k->base = (void __iomem *)dev_get_platdata(&pdev->dev);
> +	spi100k->base = dev_get_platdata(&pdev->dev);

I might be wrong, but I would assume that __iomem is the important bit
here and removing this cast will make linter unhappy.

>  
>  	spi100k->ick = devm_clk_get(&pdev->dev, "ick");
>  	if (IS_ERR(spi100k->ick)) {
> -- 
> 1.7.10.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] spi: omap-100k: Remove casting the return value which is a void pointer

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

On Mon, Dec 09, 2013 at 12:21:11PM +0100, Michal Nazarewicz wrote:
> On Mon, Dec 09 2013, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:

> > -	spi100k->base = (void __iomem *)dev_get_platdata(&pdev->dev);
> > +	spi100k->base = dev_get_platdata(&pdev->dev);

> I might be wrong, but I would assume that __iomem is the important bit
> here and removing this cast will make linter unhappy.

Yes, I'd expect so.  Jingoo have you tested with sparse?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi: omap-100k: Remove casting the return value which is a void pointer

[Jingoo Han]

On Monday, December 09, 2013 8:56 PM, Mark Brown wrote:
> On Mon, Dec 09, 2013 at 12:21:11PM +0100, Michal Nazarewicz wrote:
> > On Mon, Dec 09 2013, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 
> > > -	spi100k->base = (void __iomem *)dev_get_platdata(&pdev->dev);
> > > +	spi100k->base = dev_get_platdata(&pdev->dev);
> 
> > I might be wrong, but I would assume that __iomem is the important bit
> > here and removing this cast will make linter unhappy.
> 
> Yes, I'd expect so.  Jingoo have you tested with sparse?

Oops, I didn't test sparse warning.
This patch makes sparse warning as below:

drivers/spi/spi-omap-100k.c:444:23: warning: incorrect type in assignment (different address spaces)
drivers/spi/spi-omap-100k.c:444:23:    expected void [noderef] <asn:2>*base
drivers/spi/spi-omap-100k.c:444:23:    got void *

Please, ignore this patch.
Sorry for annoying you. :-)

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html