From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH RFC 3/4] spi: dw: add support for gpio controlled chip select Date: Thu, 23 Jan 2014 16:05:46 +0200 Message-ID: <20140123140546.GG12751@tarshish> References: <20140123132623.GN17314@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Feng Tang To: Mark Brown Return-path: Content-Disposition: inline In-Reply-To: <20140123132623.GN17314-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi Mark, On Thu, Jan 23, 2014 at 01:26:23PM +0000, Mark Brown wrote: > On Thu, Jan 23, 2014 at 03:05:58PM +0200, Baruch Siach wrote: > > Signed-off-by: Baruch Siach > > If you convert to the generic queue then there's generic support for > managing a GPIO based /CS if you set cs_gpio in the spi_device. We > should extend that for GPIO descriptors too. Thank. This further simplifies things. AFAICS the generic gpio chip select code does not request the GPIO. Is there a reason for that? > > + if (gpio_is_valid(spi->cs_gpio)) { > > + ret = gpio_request(spi->cs_gpio, dev_name(&spi->dev)); > > + if (ret) > > + return ret; > > + ret = gpio_direction_output(spi->cs_gpio, > > + !(spi->mode & SPI_CS_HIGH)); > > devm_gpio_request_one(). Right. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html