From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH RFC 4/4] spi: dw: migrate to generic queue infrastructure
Date: Thu, 23 Jan 2014 20:13:06 +0000 [thread overview]
Message-ID: <20140123201306.GP11727@sirena.org.uk> (raw)
In-Reply-To: <20140123200710.GK12751@tarshish>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On Thu, Jan 23, 2014 at 10:07:10PM +0200, Baruch Siach wrote:
> I'll look into it. I had to dig in include/linux/spi/spi.h, 'git blame' and
> commit b158935f70b9c to see how it all works together. The
> Documentation/spi/spi-summary doesn't mention the transfer_one callback. The
> kerneldoc in spi.h should make it clear that transfer_one and
> transfer_one_message are mutually exclusive.
Feel free to submit documentation patches... I'd have thought that
transfer_one_message() and transfer_one() being exclusive was fairly
obvious given that the former takes an entire message.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-23 20:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 13:05 [PATCH RFC 0/4] spi: dw: device tree and generic queue support Baruch Siach
[not found] ` <cover.1390481412.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-23 13:05 ` [PATCH RFC 1/4] spi: dw-mmio: allow multiple instances Baruch Siach
[not found] ` <74a507ce4370729cbc31c7e8d182821287ffcca1.1390481413.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-23 19:50 ` Mark Brown
2014-01-23 13:05 ` [PATCH RFC 2/4] spi: dw-mmio: add device tree support Baruch Siach
[not found] ` <4859e838c549175fbff8d5a6a70f5a02ce51008c.1390481413.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-23 13:20 ` Mark Brown
2014-01-23 13:05 ` [PATCH RFC 3/4] spi: dw: add support for gpio controlled chip select Baruch Siach
[not found] ` <cc63df805aa126eede50aa11b3fb3c5bdef67f65.1390481413.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-23 13:26 ` Mark Brown
[not found] ` <20140123132623.GN17314-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-23 14:05 ` Baruch Siach
2014-01-23 16:32 ` Mark Brown
2014-01-26 8:01 ` Baruch Siach
2014-01-23 13:05 ` [PATCH RFC 4/4] spi: dw: migrate to generic queue infrastructure Baruch Siach
[not found] ` <cb13f97edb9250d51bc03d27bcc3ddda93821bf9.1390481413.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-23 19:51 ` Mark Brown
[not found] ` <20140123195148.GL11727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-23 20:07 ` Baruch Siach
2014-01-23 20:13 ` Mark Brown [this message]
[not found] ` <20140123201306.GP11727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-01-24 6:36 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123201306.GP11727@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).