From: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 2/3] Doc: spi: document the transfer_one spi_master callback
Date: Fri, 24 Jan 2014 10:49:34 +0200 [thread overview]
Message-ID: <20140124084934.GO12751@tarshish> (raw)
In-Reply-To: <CAMuHMdVrNcs0uWfVNdXGw+HTuGHy2nGXR=tMqdzz236LGFHVoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Geert,
On Fri, Jan 24, 2014 at 09:47:10AM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 24, 2014 at 9:36 AM, Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> > +++ b/Documentation/spi/spi-summary
> > @@ -545,6 +545,16 @@ SPI MASTER METHODS
> > spi_finalize_current_message() so the subsystem can issue the next
> > transfer. This may sleep.
> >
> > + master->transfer_one(struct spi_master *master, struct spi_device *spi,
> > + struct spi_transfer *transfer)
> > + The subsystem calls the driver to transfer a single transfer while
> > + queuing transfers that arrive in the meantime. When the driver is
> > + finished with this message, it must call
> > + spi_finalize_current_transfer() so the subsystem can issue the next
> > + transfer. This may sleep. Note: transfer_one and transfer_one_message
> > + are mutually exclusive; when both are set, the generic subsystem does
> > + not call your transfer_one callback.
>
> You still forgot the updates I made in
> http://lkml.indiana.edu/hypermail/linux/kernel/1401.2/02465.html
AFAICS, your patch touches spi.h, not spi-summary. Am I missing something
here?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-24 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 8:36 [PATCH v2 0/3] spi: documentation improvements Baruch Siach
[not found] ` <cover.1390552232.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-24 8:36 ` [PATCH v2 1/3] spi: spi.h: clarify the documentation of transfer_one Baruch Siach
2014-01-24 8:36 ` [PATCH v2 2/3] Doc: spi: document the transfer_one spi_master callback Baruch Siach
[not found] ` <1abe062855111800754477d1340635b5a69d5635.1390552232.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-24 8:47 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVrNcs0uWfVNdXGw+HTuGHy2nGXR=tMqdzz236LGFHVoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-24 8:49 ` Baruch Siach [this message]
2014-01-24 8:57 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVH9XDcVGXt2CcqkABGbz4Kz9bA5M1NPSAyOnwm6u4j2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-24 9:08 ` Baruch Siach
2014-01-24 8:36 ` [PATCH v2 3/3] spi: correct the transfer_one_message documentation wording Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124084934.GO12751@tarshish \
--to=baruch-nswtu9s1w3p6gbpvegmw2w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).