[PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()

[PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()

[Christian Engelmayer]

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read().

Detected by Coverity: CID 1077860.

Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>
---
 drivers/spi/spi-orion.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index 7f2121f..75871d4 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -260,11 +260,9 @@ orion_spi_write_read_16bit(struct spi_device *spi,
 static unsigned int
 orion_spi_write_read(struct spi_device *spi, struct spi_transfer *xfer)
 {
-	struct orion_spi *orion_spi;
 	unsigned int count;
 	int word_len;
 
-	orion_spi = spi_master_get_devdata(spi->master);
 	word_len = spi->bits_per_word;
 	count = xfer->len;
 
-- 
1.8.3.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

On Wed, Feb 05, 2014 at 10:23:01PM +0100, Christian Engelmayer wrote:
> Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read().
> 
> Detected by Coverity: CID 1077860.
> 
> Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>

I'll apply this but please follow the patch submission process in
SubmittingPatches, in particular please always CC maintainers on
patches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()

[Christian Engelmayer]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

> I'll apply this but please follow the patch submission process in
> SubmittingPatches, in particular please always CC maintainers on
> patches.

Thanks. For trivial patches like this I tend to rely on get_maintainer.pl which
clearly pointed me to You. I'll put more investigation into it again next time.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

On Wed, Feb 05, 2014 at 10:54:21PM +0100, Christian Engelmayer wrote:
> > I'll apply this but please follow the patch submission process in
> > SubmittingPatches, in particular please always CC maintainers on
> > patches.

> Thanks. For trivial patches like this I tend to rely on
> get_maintainer.pl which clearly pointed me to You. I'll put more
> investigation into it again next time.

It should've listed the maintainer as broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org rather at
linaro.org which was where you sent this - IIRC you posted some other
stuff recently which missed my comaintainer on that subsystem.  Checking
right now I can't get it to give my Linaro address at all for that file,
odd.  It could find that via signoffs but it seems to have squashed
those into the maintainer section.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi: orion: Remove unused pointer in orion_spi_write_read()

[Christian Engelmayer]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

On Wed, 5 Feb 2014 22:12:26 +0000, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Feb 05, 2014 at 10:54:21PM +0100, Christian Engelmayer wrote:
> > > I'll apply this but please follow the patch submission process in
> > > SubmittingPatches, in particular please always CC maintainers on
> > > patches.
> 
> > Thanks. For trivial patches like this I tend to rely on
> > get_maintainer.pl which clearly pointed me to You. I'll put more
> > investigation into it again next time.
> 
> It should've listed the maintainer as broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org rather at
> linaro.org which was where you sent this - IIRC you posted some other
> stuff recently which missed my comaintainer on that subsystem.  Checking
> right now I can't get it to give my Linaro address at all for that file,
> odd.  It could find that via signoffs but it seems to have squashed
> those into the maintainer section.

You are right, I already recently used Your linaro address and the referenced
commit that led me to addressing You and just CC the list was signed-off-by
broonie-QSEj5FYQhm64UlQgPVntAg@public.gmane.org Interestingly I had both Your linaro/kernel.org addresses
in my MUA's address book - prefering linaro. So get_maintainer.pl in this case
chose Mark Brown, but isn't to blame for the wrong address. Again, my apologies
for the noise.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]