From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Cartwright Subject: Re: [PATCH 2/2] spi: Add Qualcomm QUP SPI controller support Date: Fri, 7 Feb 2014 11:20:51 -0600 Message-ID: <20140207172051.GW20228@joshc.qualcomm.com> References: <1391705868-20091-1-git-send-email-iivanov@mm-sol.com> <1391705868-20091-3-git-send-email-iivanov@mm-sol.com> <20140207073952.GA2610@qualcomm.com> <20140207165127.GV20228@joshc.qualcomm.com> <20140207171834.GF1757@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Kumar Gala , "Ivan T. Ivanov" , Grant Likely , Rob Herring , linux-spi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alok Chauhan , Gilad Avidov , Kiran Gunda , Sagar Dharia , Andy Gross To: Mark Brown Return-path: Content-Disposition: inline In-Reply-To: <20140207171834.GF1757@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org Hey Mark- On Fri, Feb 07, 2014 at 05:18:34PM +0000, Mark Brown wrote: > On Fri, Feb 07, 2014 at 10:51:27AM -0600, Josh Cartwright wrote: > > > config SPI_QUP > > tristate "Qualcomm SPI Support with QUP interface" > > depends on OF > > depends on ARM > > Does this really depend on ARM? If so why? The ARM dependency is there for the use of _relaxed io accessor variants. > > depends on ARCH_MSM_DT || COMPILE_TEST > > > With Kumar's pending the ARCH_MSM_DT -> ARCH_QCOM rename, we'll > > introduce a arm-soc/spi tree dependency here that we'll need to keep > > track of. > > It seems simpler to just depend on MSM_DT || ARCH_QCOM or whatever. ARCH_MSM_DT is going away, so maybe this is the best option for the short term (a later patch can remove ARCH_MSM_DT from here at some point in the future). Josh -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation