From: Wolfram Sang <wsa@the-dreams.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Alessandro Rubini <rubini@unipv.it>,
Linus Walleij <linus.walleij@linaro.org>,
Chris Ball <chris@printf.net>, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH V2 11/17] i2c: nomadik: Convert to devm functions
Date: Sat, 15 Feb 2014 16:03:45 +0100 [thread overview]
Message-ID: <20140215150345.GD2579@katana> (raw)
In-Reply-To: <1392300547-23365-1-git-send-email-ulf.hansson@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Thu, Feb 13, 2014 at 03:09:02PM +0100, Ulf Hansson wrote:
> Use devm_* functions to simplify code and error handling.
>
> Cc: Alessandro Rubini <rubini@unipv.it>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
> Rebased on top of latest i2c-nomadik branch.
Since this depends on Linus' patch already, I think it would be cleaner
if I pick this kinda unrelated (but wanted) devm patch, and ack the
PM stuff. If this for some reason makes things more complicated, I can
also simply ack this one.
> - dev->virtbase = ioremap(adev->res.start, resource_size(&adev->res));
> + dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
> + resource_size(&adev->res));
> if (!dev->virtbase) {
> ret = -ENOMEM;
IS_ERR()!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-15 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 14:09 [PATCH V2 11/17] i2c: nomadik: Convert to devm functions Ulf Hansson
[not found] ` <1392300547-23365-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-02-13 14:09 ` [PATCH V2 12/17] i2c: nomadik: Remove redundant call to pm_runtime_disable Ulf Hansson
2014-02-13 14:09 ` [PATCH V2 14/17] i2c: nomadik: Fixup deployment of runtime PM Ulf Hansson
2014-02-13 14:09 ` [PATCH V2 15/17] i2c: nomadik: Convert to late and early system PM callbacks Ulf Hansson
2014-02-13 14:09 ` [PATCH V2 16/17] i2c: nomadik: Remove busy check for transfers at suspend late Ulf Hansson
2014-02-13 14:09 ` [PATCH V2 17/17] i2c: nomadik: Fixup system suspend Ulf Hansson
2014-02-15 15:03 ` Wolfram Sang [this message]
2014-02-16 13:44 ` [PATCH V2 11/17] i2c: nomadik: Convert to devm functions Ulf Hansson
[not found] ` <CAPDyKFrt6QJVSypP5iD_oVxRUvNhzxGcbZ703zR1K8gwJ5uCeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-16 17:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215150345.GD2579@katana \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@unipv.it \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).