From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Philippe De Muyter <phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] spi: spi-imx: spi_imx_remove: do not disable disabled clocks
Date: Fri, 28 Feb 2014 15:13:44 +0900 [thread overview]
Message-ID: <20140228061344.GD29849@sirena.org.uk> (raw)
In-Reply-To: <53100FEF.7060600-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Fri, Feb 28, 2014 at 12:26:23PM +0800, Huang Shijie wrote:
> 于 2014年02月28日 11:46, Mark Brown 写道:
> > Why is the fix for this not to convert the enable/disable done when
> > tranferring to be preparing as well? The message transfer doesn't
> It will make the code run a litter slow if we also do the
> prepare/unprepare in the
> @->{un}prepare_message hooks.
> This is the only concern.
If you're worried about that then how about doing the prepares in
runtime PM and then using autosuspend to keep the clocks prepared for a
little while after the last use has finished? That's a little more
involved though and would still need this due to runtime PM being
optional.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-28 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 8:51 [PATCH] spi: spi-imx: spi_imx_remove: do not disable disabled clocks Philippe De Muyter
[not found] ` <1393491060-28074-1-git-send-email-phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>
2014-02-27 8:59 ` Huang Shijie
[not found] ` <530EFE8E.5050303-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-27 9:16 ` [PATCH v2] " Philippe De Muyter
[not found] ` <1393492575-32495-1-git-send-email-phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org>
2014-02-27 9:23 ` Huang Shijie
2014-02-28 3:46 ` Mark Brown
[not found] ` <20140228034620.GH9383-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-28 4:26 ` Huang Shijie
[not found] ` <53100FEF.7060600-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-28 6:13 ` Mark Brown [this message]
[not found] ` <20140228061344.GD29849-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-02-28 6:28 ` Huang Shijie
[not found] ` <53102C74.2070609-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-01 4:09 ` Mark Brown
2014-02-28 6:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228061344.GD29849@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=phdm-vQo90/bmh3WzQB+pC5nmwQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).