[PATCH] spi: ti-ssp: Remove duplicate code to check full duplex transfer

[PATCH] spi: ti-ssp: Remove duplicate code to check full duplex transfer

[Axel Lin]

This driver has set SPI_MASTER_HALF_DUPLEX flag, so spi core will reject full
duplex transfer. We can remove the same checking in ti_ssp_spi_transfer().

Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
 drivers/spi/spi-ti-ssp.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/spi/spi-ti-ssp.c b/drivers/spi/spi-ti-ssp.c
index 7d20e12..116640c 100644
--- a/drivers/spi/spi-ti-ssp.c
+++ b/drivers/spi/spi-ti-ssp.c
@@ -256,11 +256,6 @@ static int ti_ssp_spi_transfer(struct spi_device *spi, struct spi_message *m)
 			dev_err(&spi->dev, "invalid xfer, no buffer\n");
 			return -EINVAL;
 		}
-
-		if (t->len && t->rx_buf && t->tx_buf) {
-			dev_err(&spi->dev, "invalid xfer, full duplex\n");
-			return -EINVAL;
-		}
 	}
 
 	spin_lock(&hw->lock);
-- 
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: ti-ssp: Remove duplicate code to check full duplex transfer

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

On Tue, Mar 18, 2014 at 10:48:37AM +0800, Axel Lin wrote:
> This driver has set SPI_MASTER_HALF_DUPLEX flag, so spi core will reject full
> duplex transfer. We can remove the same checking in ti_ssp_spi_transfer().

Arnd has actually been working on removing this driver since it appears
to be unused - it got a few acks now so I just applied the patch
deleting it entirely.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]