From: Steven Rostedt <rostedt@goodmis.org>
To: Steven Miao <realmz6@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
adi-buildroot-devel@lists.sourceforge.net
Cc: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org
Subject: [PATCH] spi-bfin: Add missing gpio.h include
Date: Wed, 23 Apr 2014 22:40:35 -0400 [thread overview]
Message-ID: <20140423224035.1de64093@gandalf.local.home> (raw)
Running my ktest.pl tests on all the archs, I stumbled over this for
3.15-rc2:
drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_cs_active':
drivers/spi/spi-bfin5xx.c:169:3: error: implicit declaration of function 'gpio_set_value' [-Werror=implicit-function-declaration]
drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_setup':
drivers/spi/spi-bfin5xx.c:1097:4: error: implicit declaration of function 'gpio_request' [-Werror=implicit-function-declaration]
drivers/spi/spi-bfin5xx.c:1102:4: error: implicit declaration of function 'gpio_direction_output' [-Werror=implicit-function-declaration]
drivers/spi/spi-bfin5xx.c:1130:3: error: implicit declaration of function 'gpio_free' [-Werror=implicit-function-declaration]
The problem is that the spi-bfin5xx driver is missing an include for
the gpio.h file.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c
index 55e57c3..da8baa5 100644
--- a/drivers/spi/spi-bfin5xx.c
+++ b/drivers/spi/spi-bfin5xx.c
@@ -15,6 +15,7 @@
#include <linux/slab.h>
#include <linux/io.h>
#include <linux/ioport.h>
+#include <linux/gpio.h>
#include <linux/irq.h>
#include <linux/errno.h>
#include <linux/interrupt.h>
next reply other threads:[~2014-04-24 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 2:40 Steven Rostedt [this message]
2014-04-24 10:33 ` [PATCH] spi-bfin: Add missing gpio.h include Mark Brown
2014-04-24 11:33 ` Mark Brown
[not found] ` <20140424113346.GM12304-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-04-24 12:34 ` Steven Rostedt
2014-04-24 12:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423224035.1de64093@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=realmz6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).