From: Guenter Roeck <linux@roeck-us.net>
To: David Wood <david@dtwood.co.uk>
Cc: Nick Krause <xerofoiffy@gmail.com>,
Mark Brown <broonie@kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: [PATCH] spi: Fix warning about redefinition
Date: Wed, 6 Aug 2014 12:18:34 -0700 [thread overview]
Message-ID: <20140806191834.GA12488@roeck-us.net> (raw)
In-Reply-To: <CAO+Sx3ncSgmdQq-PyZwXzN-ZJJ+0VD+kNVNJYzir+mHzVwxbdw@mail.gmail.com>
On Wed, Aug 06, 2014 at 09:07:04PM +0200, David Wood wrote:
> On 6 August 2014 21:04, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Wed, Aug 06, 2014 at 08:53:41PM +0200, David Wood wrote:
> > ...
> > That was purely to ensure that there is no hidden use through a macro
> > defined elsewhere, not a suggestion for a real patch.
> >
> > Guenter
>
> I also managed not to notice that I had in fact shown that the fs.h
> definitions were the opposite of those in the spi driver, so it would
> in fact be significant if they were swapped.
>
See it positively: There is someone out there doing an excellent job
of forcing various kernel maintainers to have a close look into areas
of the kernel they would otherwise never look at. In addition to that,
we all gain valuable knowledge on how to validate patches.
Guenter
next prev parent reply other threads:[~2014-08-06 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 18:53 [PATCH] spi: Fix warning about redefinition David Wood
2014-08-06 19:04 ` Guenter Roeck
[not found] ` <20140806190412.GA5605-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-08-06 19:07 ` David Wood
2014-08-06 19:18 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-06 16:55 Nick Krause
[not found] ` <1407344128-9754-1-git-send-email-xerofoiffy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-06 17:19 ` Richard Weinberger
[not found] ` <CAFLxGvxfSD+dW1oUyKAqq8tUMHYS7fuJdsdRKOR94O+nD8RoMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-06 18:33 ` Guenter Roeck
2014-08-06 17:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806191834.GA12488@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=david@dtwood.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=xerofoiffy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).