[PATCH 1/2] spi: xilinx: Remove .owner field for driver

[PATCH 1/2] spi: xilinx: Remove .owner field for driver

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

There is no need to init .owner field.

Based on the patch from Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
"mmc: remove .owner field for drivers using module_platform_driver"

This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."

Signed-off-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
---

 drivers/spi/spi-xilinx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index 4d8efb16573d..79bd84f43430 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -471,7 +471,6 @@ static struct platform_driver xilinx_spi_driver = {
 	.remove = xilinx_spi_remove,
 	.driver = {
 		.name = XILINX_SPI_NAME,
-		.owner = THIS_MODULE,
 		.of_match_table = xilinx_spi_of_match,
 	},
 };
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

[PATCH 2/2] spi: cadence: Remove .owner field for driver

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

There is no need to init .owner field.

Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"

This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/spi/spi-cadence.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 562ff83debd9..7b811e38c7ad 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -677,7 +677,6 @@ static struct platform_driver cdns_spi_driver = {
 	.remove	= cdns_spi_remove,
 	.driver = {
 		.name = CDNS_SPI_NAME,
-		.owner = THIS_MODULE,
 		.of_match_table = cdns_spi_of_match,
 		.pm = &cdns_spi_dev_pm_ops,
 	},
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 1/2] spi: xilinx: Remove .owner field for driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Wed, Aug 13, 2014 at 01:52:39PM +0200, Michal Simek wrote:
> There is no need to init .owner field.
> 
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
> 
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."

Would it not be better to do this as a tree wide or at least subsystem
wide sweep with something like cocinelle?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/2] spi: xilinx: Remove .owner field for driver

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On 08/13/2014 02:33 PM, Mark Brown wrote:
> On Wed, Aug 13, 2014 at 01:52:39PM +0200, Michal Simek wrote:
>> There is no need to init .owner field.
>>
>> Based on the patch from Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> "mmc: remove .owner field for drivers using module_platform_driver"
>>
>> This patch removes the superflous .owner field for drivers which
>> use the module_platform_driver API, as this is overriden in
>> platform_driver_register anyway."
> 
> Would it not be better to do this as a tree wide or at least subsystem
> wide sweep with something like cocinelle?

Feel free to use cocinelle for fixing this everywhere.
For me was just easier to fix all xilinx drivers to ensure
that none else will copy it for new drivers.

Thanks,
Michal




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 1/2] spi: xilinx: Remove .owner field for driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

On Wed, Aug 13, 2014 at 03:21:29PM +0200, Michal Simek wrote:
> On 08/13/2014 02:33 PM, Mark Brown wrote:

> > Would it not be better to do this as a tree wide or at least subsystem
> > wide sweep with something like cocinelle?

> Feel free to use cocinelle for fixing this everywhere.
> For me was just easier to fix all xilinx drivers to ensure
> that none else will copy it for new drivers.

I'd expect people would be more likely to copy a random driver for the
subsystem they're working with than specifically a Xilinx driver...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]