Re: [PATCH v4] spi: spi-imx: add DMA support

[Robin Gong <b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]

On Tue, Aug 26, 2014 at 09:26:40AM +0200, Marek Vasut wrote:
> On Tuesday, August 26, 2014 at 09:17:59 AM, Robin Gong wrote:
> > On Mon, Aug 25, 2014 at 10:07:22AM +0200, Marek Vasut wrote:
> > > On Saturday, August 23, 2014 at 02:13:55 AM, Robin Gong wrote:
> > > > After enable DMA
> > > 
> > > Please also add a commit message which describes the change, not only
> > > some test results.
> > > 
> > > [...]
> > 
> >  Ok, I will enrich it in next version.
> > 
> > > > @@ -911,6 +1194,13 @@ static int spi_imx_probe(struct platform_device
> > > > *pdev) goto out_put_per;
> > > > 
> > > >  	spi_imx->spi_clk = clk_get_rate(spi_imx->clk_per);
> > > > 
> > > > +	/*
> > > > +	 * Only validated on i.mx6 now, can remove the constrain if validated
> > > > on +	 * other chips.
> > > > +	 */
> > > 
> > > Given that the check below tests for imx51_ecspi_devtype_data ... does
> > > that mean, that this code was never tested on MX51 and MX53, yet will be
> > > enabled for those chips and might possibly break them ?
> > 
> > Yes, because there is no available mx51 mx53 boards in my hands. But I
> > think it won't bring too much trouble, since they share the same IP.
> > No, the patch won't break current MX51 and MX53, because they didn't enable
> > dma in dts setting,and they will keep use pio mode.
> 
> Thanks for clearing this up, this was the important piece of information for me. 
> Please put it into the commit message.
>
 Okay. Thanks for your reminding.
> Best regards,
> Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html