From: Robin Gong <b38343@freescale.com>
To: sanjeev sharma <sanjeevsharmaengg@gmail.com>
Cc: marex@denx.de, Frank.Li@freescale.com,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-spi@vger.kernel.org, broonie@kernel.org,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] spi: spi-imx: add DMA support
Date: Thu, 28 Aug 2014 17:59:41 +0800 [thread overview]
Message-ID: <20140828095939.GA13274@Robin-OptiPlex-780> (raw)
In-Reply-To: <CAGUYZuQre3RAQy+qqwq5HthrjnT85V5RKu2xwXOC=gL6Yk33TQ@mail.gmail.com>
On Wed, Aug 27, 2014 at 11:12:08AM +0530, sanjeev sharma wrote:
> On Sat, Aug 23, 2014 at 5:43 AM, Robin Gong <b38343@freescale.com> wrote:
>
> > + /*
> > + * Configure the DMA register: setup the watermark
> > + * and enable DMA request.
> > + */
> > + if (spi_imx->dma_is_inited) {
> > + dma = readl(spi_imx->base + MX51_ECSPI_DMA);
> > +
> > + spi_imx->tx_wml = spi_imx_get_fifosize(spi_imx) / 2;
> > + spi_imx->rx_wml = spi_imx_get_fifosize(spi_imx) / 2;
> > + spi_imx->rxt_wml = spi_imx_get_fifosize(spi_imx) / 2;
> > + rx_wml_cfg = spi_imx->rx_wml <<
> > MX51_ECSPI_DMA_RX_WML_OFFSET;
> > + tx_wml_cfg = spi_imx->tx_wml <<
> > MX51_ECSPI_DMA_TX_WML_OFFSET;
> > + rxt_wml_cfg = spi_imx->rxt_wml <<
> > MX51_ECSPI_DMA_RXT_WML_OFFSET;
> > + dma = (dma & ~MX51_ECSPI_DMA_TX_WML_MASK
> > + & ~MX51_ECSPI_DMA_RX_WML_MASK
> > + & ~MX51_ECSPI_DMA_RXT_WML_MASK)
> > + | rx_wml_cfg | tx_wml_cfg | rxt_wml_cfg
> > + |(1 << MX51_ECSPI_DMA_TEDEN_OFFSET)
> > + |(1 << MX51_ECSPI_DMA_RXDEN_OFFSET)
> > + |(1 << MX51_ECSPI_DMA_RXTDEN_OFFSET);
> > +
> >
>
> IMO, we should have an seperate function for dmactrl,rx_threshold &
> tx_threshold for better visiblity.
>
>
I understood your concern, but I don't want to create one function only for
setting some bit fields of the register.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
prev parent reply other threads:[~2014-08-28 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 0:13 [PATCH v4] spi: spi-imx: add DMA support Robin Gong
[not found] ` <1408752835-10995-1-git-send-email-b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-08-25 8:07 ` Marek Vasut
2014-08-26 7:17 ` Robin Gong
2014-08-26 7:26 ` Marek Vasut
[not found] ` <201408260926.41038.marex-ynQEQJNshbs@public.gmane.org>
2014-08-26 7:52 ` Robin Gong
[not found] ` <CAGUYZuQre3RAQy+qqwq5HthrjnT85V5RKu2xwXOC=gL6Yk33TQ@mail.gmail.com>
2014-08-28 9:59 ` Robin Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828095939.GA13274@Robin-OptiPlex-780 \
--to=b38343@freescale.com \
--cc=Frank.Li@freescale.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=sanjeevsharmaengg@gmail.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).