linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/9] spi: davinci: Fix checkpatch issue
@ 2014-09-02  2:48 Jingoo Han
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:48 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Grygorii Strashko',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: Missing a blank line after declarations
  WARNING: quoted string split across lines

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-davinci.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index 48f1d26e6ad9..cb20d6c482a6 100644
--- a/drivers/spi/spi-davinci.c
+++ b/drivers/spi/spi-davinci.c
@@ -167,8 +167,10 @@ static void davinci_spi_rx_buf_u16(u32 data, struct davinci_spi *dspi)
 static u32 davinci_spi_tx_buf_u8(struct davinci_spi *dspi)
 {
 	u32 data = 0;
+
 	if (dspi->tx) {
 		const u8 *tx = dspi->tx;
+
 		data = *tx++;
 		dspi->tx = tx;
 	}
@@ -178,8 +180,10 @@ static u32 davinci_spi_tx_buf_u8(struct davinci_spi *dspi)
 static u32 davinci_spi_tx_buf_u16(struct davinci_spi *dspi)
 {
 	u32 data = 0;
+
 	if (dspi->tx) {
 		const u16 *tx = dspi->tx;
+
 		data = *tx++;
 		dspi->tx = tx;
 	}
@@ -985,8 +989,8 @@ static int davinci_spi_probe(struct platform_device *pdev)
 			goto free_clk;
 
 		dev_info(&pdev->dev, "DMA: supported\n");
-		dev_info(&pdev->dev, "DMA: RX channel: %pa, TX channel: %pa, "
-				"event queue: %d\n", &dma_rx_chan, &dma_tx_chan,
+		dev_info(&pdev->dev, "DMA: RX channel: %pa, TX channel: %pa, event queue: %d\n",
+				&dma_rx_chan, &dma_tx_chan,
 				pdata->dma_event_q);
 	}
 
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/9] spi: dw: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-09-02  2:49   ` Jingoo Han
  2014-09-02  2:50   ` [PATCH 3/9] spi: ep93xx: " Jingoo Han
                     ` (7 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:49 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Baruch Siach',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
  WARNING: min() should probably be min_t(u32, rx_left, dw_readw(dws, DW_SPI_RXFLR))
  WARNING: else is not generally useful after a break or return
  WARNING: Missing a blank line after declarations
  WARNING: void function return statements are not generally useful

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-dw.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index 670f0627f3bf..f6e1ee658720 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -135,8 +135,7 @@ static int mrst_spi_debugfs_init(struct dw_spi *dws)
 
 static void mrst_spi_debugfs_remove(struct dw_spi *dws)
 {
-	if (dws->debugfs)
-		debugfs_remove_recursive(dws->debugfs);
+	debugfs_remove_recursive(dws->debugfs);
 }
 
 #else
@@ -177,7 +176,7 @@ static inline u32 rx_max(struct dw_spi *dws)
 {
 	u32 rx_left = (dws->rx_end - dws->rx) / dws->n_bytes;
 
-	return min(rx_left, (u32)dw_readw(dws, DW_SPI_RXFLR));
+	return min_t(u32, rx_left, dw_readw(dws, DW_SPI_RXFLR));
 }
 
 static void dw_writer(struct dw_spi *dws)
@@ -228,8 +227,9 @@ static void *next_transfer(struct dw_spi *dws)
 					struct spi_transfer,
 					transfer_list);
 		return RUNNING_STATE;
-	} else
-		return DONE_STATE;
+	}
+
+	return DONE_STATE;
 }
 
 /*
@@ -471,10 +471,12 @@ static void pump_transfers(unsigned long data)
 	 */
 	if (!dws->dma_mapped && !chip->poll_mode) {
 		int templen = dws->len / dws->n_bytes;
+
 		txint_level = dws->fifo_len / 2;
 		txint_level = (templen > txint_level) ? txint_level : templen;
 
-		imask |= SPI_INT_TXEI | SPI_INT_TXOI | SPI_INT_RXUI | SPI_INT_RXOI;
+		imask |= SPI_INT_TXEI | SPI_INT_TXOI |
+			 SPI_INT_RXUI | SPI_INT_RXOI;
 		dws->transfer_handler = interrupt_transfer;
 	}
 
@@ -515,7 +517,6 @@ static void pump_transfers(unsigned long data)
 
 early_exit:
 	giveback(dws);
-	return;
 }
 
 static int dw_spi_transfer_one_message(struct spi_master *master,
@@ -619,6 +620,7 @@ static void spi_hw_init(struct dw_spi *dws)
 	 */
 	if (!dws->fifo_len) {
 		u32 fifo;
+
 		for (fifo = 2; fifo <= 257; fifo++) {
 			dw_writew(dws, DW_SPI_TXFLTR, fifo);
 			if (fifo != dw_readw(dws, DW_SPI_TXFLTR))
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 3/9] spi: ep93xx: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02  2:49   ` [PATCH 2/9] spi: dw: " Jingoo Han
@ 2014-09-02  2:50   ` Jingoo Han
       [not found]     ` <002301cfc658$9eb72c60$dc258520$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02  2:50   ` [PATCH 4/9] spi: spi-mxs: " Jingoo Han
                     ` (6 subsequent siblings)
  8 siblings, 1 reply; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:50 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Mika Westerberg',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: Missing a blank line after declarations

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-ep93xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index 2f675d32df0e..bf9728773247 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -266,6 +266,7 @@ static int ep93xx_spi_setup(struct spi_device *spi)
 
 		if (chip->ops && chip->ops->setup) {
 			int ret = chip->ops->setup(spi);
+
 			if (ret) {
 				kfree(chip);
 				return ret;
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 4/9] spi: spi-mxs: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02  2:49   ` [PATCH 2/9] spi: dw: " Jingoo Han
  2014-09-02  2:50   ` [PATCH 3/9] spi: ep93xx: " Jingoo Han
@ 2014-09-02  2:50   ` Jingoo Han
       [not found]     ` <002401cfc658$b32398f0$196acad0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02  2:51   ` [PATCH 5/9] spi: orion: " Jingoo Han
                     ` (5 subsequent siblings)
  8 siblings, 1 reply; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:50 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Marek Vašut',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: Missing a blank line after declarations
  WARNING: Prefer kcalloc over kzalloc with multiply

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-mxs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 2884f0c2f5f0..c3f8d3a22472 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -154,12 +154,14 @@ static int mxs_ssp_wait(struct mxs_spi *spi, int offset, int mask, bool set)
 static void mxs_ssp_dma_irq_callback(void *param)
 {
 	struct mxs_spi *spi = param;
+
 	complete(&spi->c);
 }
 
 static irqreturn_t mxs_ssp_irq_handler(int irq, void *dev_id)
 {
 	struct mxs_ssp *ssp = dev_id;
+
 	dev_err(ssp->dev, "%s[%i] CTRL1=%08x STATUS=%08x\n",
 		__func__, __LINE__,
 		readl(ssp->base + HW_SSP_CTRL1(ssp)),
@@ -189,7 +191,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi,
 	if (!len)
 		return -EINVAL;
 
-	dma_xfer = kzalloc(sizeof(*dma_xfer) * sgs, GFP_KERNEL);
+	dma_xfer = kcalloc(sgs, sizeof(*dma_xfer), GFP_KERNEL);
 	if (!dma_xfer)
 		return -ENOMEM;
 
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 5/9] spi: orion: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
                     ` (2 preceding siblings ...)
  2014-09-02  2:50   ` [PATCH 4/9] spi: spi-mxs: " Jingoo Han
@ 2014-09-02  2:51   ` Jingoo Han
  2014-09-02  2:52   ` [PATCH 6/9] spi: tegra114: " Jingoo Han
                     ` (4 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:51 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Jason Cooper',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: else is not generally useful after a break or return
  WARNING: Missing a blank line after declarations

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-orion.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index c4675fa8b645..345e7d61c399 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -179,8 +179,8 @@ static inline int orion_spi_wait_till_ready(struct orion_spi *orion_spi)
 	for (i = 0; i < ORION_SPI_WAIT_RDY_MAX_LOOP; i++) {
 		if (readl(spi_reg(orion_spi, ORION_SPI_INT_CAUSE_REG)))
 			return 1;
-		else
-			udelay(1);
+
+		udelay(1);
 	}
 
 	return -1;
@@ -360,6 +360,7 @@ static int orion_spi_probe(struct platform_device *pdev)
 		master->bus_num = pdev->id;
 	if (pdev->dev.of_node) {
 		u32 cell_index;
+
 		if (!of_property_read_u32(pdev->dev.of_node, "cell-index",
 					  &cell_index))
 			master->bus_num = cell_index;
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 6/9] spi: tegra114: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
                     ` (3 preceding siblings ...)
  2014-09-02  2:51   ` [PATCH 5/9] spi: orion: " Jingoo Han
@ 2014-09-02  2:52   ` Jingoo Han
  2014-09-02  2:53   ` [PATCH 7/9] spi: tegra20-sflash: " Jingoo Han
                     ` (3 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:52 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Laxman Dewangan',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: Missing a blank line after declarations

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-tegra114.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index e4a85ada861d..795bcbc0131b 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -302,6 +302,7 @@ static unsigned tegra_spi_fill_tx_fifo_from_client_txbuf(
 		max_n_32bit = DIV_ROUND_UP(nbytes, 4);
 		for (count = 0; count < max_n_32bit; count++) {
 			u32 x = 0;
+
 			for (i = 0; (i < 4) && nbytes; i++, nbytes--)
 				x |= (u32)(*tx_buf++) << (i * 8);
 			tegra_spi_writel(tspi, x, SPI_TX_FIFO);
@@ -312,6 +313,7 @@ static unsigned tegra_spi_fill_tx_fifo_from_client_txbuf(
 		nbytes = written_words * tspi->bytes_per_word;
 		for (count = 0; count < max_n_32bit; count++) {
 			u32 x = 0;
+
 			for (i = 0; nbytes && (i < tspi->bytes_per_word);
 							i++, nbytes--)
 				x |= (u32)(*tx_buf++) << (i * 8);
@@ -338,6 +340,7 @@ static unsigned int tegra_spi_read_rx_fifo_to_client_rxbuf(
 		len = tspi->curr_dma_words * tspi->bytes_per_word;
 		for (count = 0; count < rx_full_count; count++) {
 			u32 x = tegra_spi_readl(tspi, SPI_RX_FIFO);
+
 			for (i = 0; len && (i < 4); i++, len--)
 				*rx_buf++ = (x >> i*8) & 0xFF;
 		}
@@ -345,8 +348,10 @@ static unsigned int tegra_spi_read_rx_fifo_to_client_rxbuf(
 		read_words += tspi->curr_dma_words;
 	} else {
 		u32 rx_mask = ((u32)1 << t->bits_per_word) - 1;
+
 		for (count = 0; count < rx_full_count; count++) {
 			u32 x = tegra_spi_readl(tspi, SPI_RX_FIFO) & rx_mask;
+
 			for (i = 0; (i < tspi->bytes_per_word); i++)
 				*rx_buf++ = (x >> (i*8)) & 0xFF;
 		}
@@ -365,6 +370,7 @@ static void tegra_spi_copy_client_txbuf_to_spi_txbuf(
 
 	if (tspi->is_packed) {
 		unsigned len = tspi->curr_dma_words * tspi->bytes_per_word;
+
 		memcpy(tspi->tx_dma_buf, t->tx_buf + tspi->cur_pos, len);
 	} else {
 		unsigned int i;
@@ -374,6 +380,7 @@ static void tegra_spi_copy_client_txbuf_to_spi_txbuf(
 
 		for (count = 0; count < tspi->curr_dma_words; count++) {
 			u32 x = 0;
+
 			for (i = 0; consume && (i < tspi->bytes_per_word);
 							i++, consume--)
 				x |= (u32)(*tx_buf++) << (i * 8);
@@ -396,6 +403,7 @@ static void tegra_spi_copy_spi_rxbuf_to_client_rxbuf(
 
 	if (tspi->is_packed) {
 		unsigned len = tspi->curr_dma_words * tspi->bytes_per_word;
+
 		memcpy(t->rx_buf + tspi->cur_rx_pos, tspi->rx_dma_buf, len);
 	} else {
 		unsigned int i;
@@ -405,6 +413,7 @@ static void tegra_spi_copy_spi_rxbuf_to_client_rxbuf(
 
 		for (count = 0; count < tspi->curr_dma_words; count++) {
 			u32 x = tspi->rx_dma_buf[count] & rx_mask;
+
 			for (i = 0; (i < tspi->bytes_per_word); i++)
 				*rx_buf++ = (x >> (i*8)) & 0xFF;
 		}
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 7/9] spi: tegra20-sflash: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
                     ` (4 preceding siblings ...)
  2014-09-02  2:52   ` [PATCH 6/9] spi: tegra114: " Jingoo Han
@ 2014-09-02  2:53   ` Jingoo Han
  2014-09-02  2:53   ` [PATCH 8/9] spi: txx9: " Jingoo Han
                     ` (2 subsequent siblings)
  8 siblings, 0 replies; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:53 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Laxman Dewangan',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: macros should not use a trailing semicolon
  WARNING: Missing a blank line after declarations

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-tegra20-sflash.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 3548ce25c08f..cd66fe7b78a9 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -99,7 +99,7 @@
 #define SPI_TX_TRIG_MASK		(0x3 << 16)
 #define SPI_TX_TRIG_1W			(0x0 << 16)
 #define SPI_TX_TRIG_4W			(0x1 << 16)
-#define SPI_DMA_BLK_COUNT(count)	(((count) - 1) & 0xFFFF);
+#define SPI_DMA_BLK_COUNT(count)	(((count) - 1) & 0xFFFF)
 
 #define SPI_TX_FIFO			0x10
 #define SPI_RX_FIFO			0x20
@@ -221,6 +221,7 @@ static int tegra_sflash_read_rx_fifo_to_client_rxbuf(
 	while (!(status & SPI_RXF_EMPTY)) {
 		int i;
 		u32 x = tegra_sflash_readl(tsd, SPI_RX_FIFO);
+
 		for (i = 0; (i < tsd->bytes_per_word); i++)
 			*rx_buf++ = (x >> (i*8)) & 0xFF;
 		read_words++;
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 8/9] spi: txx9: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
                     ` (5 preceding siblings ...)
  2014-09-02  2:53   ` [PATCH 7/9] spi: tegra20-sflash: " Jingoo Han
@ 2014-09-02  2:53   ` Jingoo Han
  2014-09-02  2:54   ` [PATCH 9/9] spi: xtensa-xtfpga: " Jingoo Han
  2014-09-03 18:30   ` [PATCH 1/9] spi: davinci: " Mark Brown
  8 siblings, 0 replies; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:53 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Atsushi Nemoto',
	'Jingoo Han'

Fix the following checkpatch warnings.

  Missing a blank line after declarations.

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-txx9.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-txx9.c b/drivers/spi/spi-txx9.c
index 5f183baa91a9..2501a8373e89 100644
--- a/drivers/spi/spi-txx9.c
+++ b/drivers/spi/spi-txx9.c
@@ -97,6 +97,7 @@ static void txx9spi_cs_func(struct spi_device *spi, struct txx9spi *c,
 		int on, unsigned int cs_delay)
 {
 	int val = (spi->mode & SPI_CS_HIGH) ? on : !on;
+
 	if (on) {
 		/* deselect the chip with cs_change hint in last transfer */
 		if (c->last_chipselect >= 0)
@@ -188,6 +189,7 @@ static void txx9spi_work_one(struct txx9spi *c, struct spi_message *m)
 		if (prev_speed_hz != speed_hz
 				|| prev_bits_per_word != bits_per_word) {
 			int n = DIV_ROUND_UP(c->baseclk, speed_hz) - 1;
+
 			n = clamp(n, SPI_MIN_DIVIDER, SPI_MAX_DIVIDER);
 			/* enter config mode */
 			txx9spi_wr(c, mcr | TXx9_SPMCR_CONFIG | TXx9_SPMCR_BCLR,
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 9/9] spi: xtensa-xtfpga: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
                     ` (6 preceding siblings ...)
  2014-09-02  2:53   ` [PATCH 8/9] spi: txx9: " Jingoo Han
@ 2014-09-02  2:54   ` Jingoo Han
       [not found]     ` <002901cfc659$3b9a9850$b2cfc8f0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-03 18:30   ` [PATCH 1/9] spi: davinci: " Mark Brown
  8 siblings, 1 reply; 16+ messages in thread
From: Jingoo Han @ 2014-09-02  2:54 UTC (permalink / raw)
  To: 'Mark Brown'
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Max Filippov',
	'Jingoo Han'

Fix the following checkpatch warnings.

  WARNING: Missing a blank line after declarations

Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/spi/spi-xtensa-xtfpga.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-xtensa-xtfpga.c b/drivers/spi/spi-xtensa-xtfpga.c
index 41e158187f9d..0dc5df5233a9 100644
--- a/drivers/spi/spi-xtensa-xtfpga.c
+++ b/drivers/spi/spi-xtensa-xtfpga.c
@@ -46,6 +46,7 @@ static inline unsigned int xtfpga_spi_read32(const struct xtfpga_spi *spi,
 static inline void xtfpga_spi_wait_busy(struct xtfpga_spi *xspi)
 {
 	unsigned i;
+
 	for (i = 0; xtfpga_spi_read32(xspi, XTFPGA_SPI_BUSY) &&
 	     i < BUSY_WAIT_US; ++i)
 		udelay(1);
-- 
2.0.0


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/9] spi: ep93xx: Fix checkpatch issue
       [not found]     ` <002301cfc658$9eb72c60$dc258520$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-09-02  5:02       ` Mika Westerberg
  2014-09-02 10:47       ` Mark Brown
  1 sibling, 0 replies; 16+ messages in thread
From: Mika Westerberg @ 2014-09-02  5:02 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA

On Tue, Sep 2, 2014 at 5:50 AM, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Fix the following checkpatch warnings.
>
>   WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Acked-by: Mika Westerberg <mika.westerberg-X3B1VOXEql0@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 9/9] spi: xtensa-xtfpga: Fix checkpatch issue
       [not found]     ` <002901cfc659$3b9a9850$b2cfc8f0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-09-02  9:46       ` Max Filippov
  2014-09-02 10:47       ` Mark Brown
  1 sibling, 0 replies; 16+ messages in thread
From: Max Filippov @ 2014-09-02  9:46 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Tue, Sep 2, 2014 at 6:54 AM, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Fix the following checkpatch warnings.
>
>   WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/spi/spi-xtensa-xtfpga.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Max Filippov <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/9] spi: ep93xx: Fix checkpatch issue
       [not found]     ` <002301cfc658$9eb72c60$dc258520$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02  5:02       ` Mika Westerberg
@ 2014-09-02 10:47       ` Mark Brown
  1 sibling, 0 replies; 16+ messages in thread
From: Mark Brown @ 2014-09-02 10:47 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Mika Westerberg'

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

On Tue, Sep 02, 2014 at 11:50:13AM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.
> 
>   WARNING: Missing a blank line after declarations

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 9/9] spi: xtensa-xtfpga: Fix checkpatch issue
       [not found]     ` <002901cfc659$3b9a9850$b2cfc8f0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02  9:46       ` Max Filippov
@ 2014-09-02 10:47       ` Mark Brown
  1 sibling, 0 replies; 16+ messages in thread
From: Mark Brown @ 2014-09-02 10:47 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Max Filippov'

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

On Tue, Sep 02, 2014 at 11:54:37AM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.
> 
>   WARNING: Missing a blank line after declarations

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/9] spi: spi-mxs: Fix checkpatch issue
       [not found]     ` <002401cfc658$b32398f0$196acad0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-09-02 12:15       ` Marek Vasut
  2014-09-02 16:32       ` Mark Brown
  1 sibling, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2014-09-02 12:15 UTC (permalink / raw)
  To: Jingoo Han; +Cc: 'Mark Brown', linux-spi-u79uwXL29TY76Z2rM5mHXA

On Tuesday, September 02, 2014 at 04:50:48 AM, Jingoo Han wrote:
> Fix the following checkpatch warnings.
> 
>   WARNING: Missing a blank line after declarations
>   WARNING: Prefer kcalloc over kzalloc with multiply
> 
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Obviously makes sense, thanks!

Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/9] spi: spi-mxs: Fix checkpatch issue
       [not found]     ` <002401cfc658$b32398f0$196acad0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-09-02 12:15       ` Marek Vasut
@ 2014-09-02 16:32       ` Mark Brown
  1 sibling, 0 replies; 16+ messages in thread
From: Mark Brown @ 2014-09-02 16:32 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Marek Vašut'

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Tue, Sep 02, 2014 at 11:50:48AM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.
> 
>   WARNING: Missing a blank line after declarations
>   WARNING: Prefer kcalloc over kzalloc with multiply

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/9] spi: davinci: Fix checkpatch issue
       [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
                     ` (7 preceding siblings ...)
  2014-09-02  2:54   ` [PATCH 9/9] spi: xtensa-xtfpga: " Jingoo Han
@ 2014-09-03 18:30   ` Mark Brown
  8 siblings, 0 replies; 16+ messages in thread
From: Mark Brown @ 2014-09-03 18:30 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA, 'Grygorii Strashko'

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

On Tue, Sep 02, 2014 at 11:48:00AM +0900, Jingoo Han wrote:
> Fix the following checkpatch warnings.
> 
>   WARNING: Missing a blank line after declarations
>   WARNING: quoted string split across lines

Applied all the rest, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2014-09-03 18:30 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02  2:48 [PATCH 1/9] spi: davinci: Fix checkpatch issue Jingoo Han
     [not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02  2:49   ` [PATCH 2/9] spi: dw: " Jingoo Han
2014-09-02  2:50   ` [PATCH 3/9] spi: ep93xx: " Jingoo Han
     [not found]     ` <002301cfc658$9eb72c60$dc258520$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02  5:02       ` Mika Westerberg
2014-09-02 10:47       ` Mark Brown
2014-09-02  2:50   ` [PATCH 4/9] spi: spi-mxs: " Jingoo Han
     [not found]     ` <002401cfc658$b32398f0$196acad0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 12:15       ` Marek Vasut
2014-09-02 16:32       ` Mark Brown
2014-09-02  2:51   ` [PATCH 5/9] spi: orion: " Jingoo Han
2014-09-02  2:52   ` [PATCH 6/9] spi: tegra114: " Jingoo Han
2014-09-02  2:53   ` [PATCH 7/9] spi: tegra20-sflash: " Jingoo Han
2014-09-02  2:53   ` [PATCH 8/9] spi: txx9: " Jingoo Han
2014-09-02  2:54   ` [PATCH 9/9] spi: xtensa-xtfpga: " Jingoo Han
     [not found]     ` <002901cfc659$3b9a9850$b2cfc8f0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02  9:46       ` Max Filippov
2014-09-02 10:47       ` Mark Brown
2014-09-03 18:30   ` [PATCH 1/9] spi: davinci: " Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).